I think we're generally OK.  The enum's natural order is the same order used by the JLS and most style guides and we're relying on that in the JavaWriter (line 731). So, I think that the test cases as they stand should be fine since it should always ensures that the output is in the correct order.  I.e. all tests have an implicit andModifiersEmitInOrder on them.