Web Inspector: Breakpoint Action JS Editor has line wrapping issues with long no-space lines
https://bugs.webkit.org/show_bug.cgi?id=120822

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-05
Reviewed by Timothy Hatcher.

* UserInterface/BreakpointActionView.css:
(.breakpoint-action-eval-editor > .CodeMirror):
(.breakpoint-action-eval-editor > .CodeMirror-scroll):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix build warnings by unused parameter
https://bugs.webkit.org/show_bug.cgi?id=120821

Reviewed by Anders Carlsson.

Fix warning by removing unused parameter.

* platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkGetProperty):
(webkitTextSinkSetProperty):
* platform/network/soup/SynchronousLoaderClientSoup.cpp:
(WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
INSTALL_PATH_PREFIX is used even when not installing
https://bugs.webkit.org/show_bug.cgi?id=120810

Reviewed by Andy Estes.

* Configurations/CopyWTFHeaders.xcconfig: Removed INSTALL_PATH_PREFIX from
the definition of PRIVATE_HEADERS_FOLDER_PATH. Also removed the leading
slash, because the Xcode definition of this build setting is relative.
* WTF.xcodeproj/project.pbxproj: Prepend INSTALL_PATH_PREFIX here when installing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
INSTALL_PATH_PREFIX is used even when not installing
https://bugs.webkit.org/show_bug.cgi?id=120818

Reviewed by Darin Adler.

* Configurations/ANGLE.xcconfig: Changed the definition of PRIVATE_HEADERS_FOLDER_PATH
to include INSTALL_PATH_PREFIX only when installing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening.

* platform/efl-wk1/TestExpectations: Failing after r155014.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
FrameView: Constructor should take Frame&.
<https://webkit.org/b/120824>

Reviewed by Anders Carlsson.

* WebCore.exp.in:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
* page/Frame.cpp:
(WebCore::Frame::createView):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::create):
* page/FrameView.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=117206

Patch by Brendan Long <b.long@cablelabs.com> on 2013-09-05
Reviewed by Philippe Normand.

.:

* Source/widgetsapi.pri: Don't include DefaultFullScreenVideoHandler when it's disabled.

Source/WebCore:

No new tests because this just fixes a build warning.

* Target.pri: Don't include PlatformVideoWindow* files in the build when they are disabled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DRY out srcset related deviceScaleFactor calculations
https://bugs.webkit.org/show_bug.cgi?id=120791

Identical deviceScaleFactor calculations were performed in 3 different locations.
I've added that calculation as a method of Document.
Previous calculations are replaced by calls to this method.

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-05
Reviewed by Andreas Kling.

No new tests since this is a refactoring change. No functionality have changed.

* dom/Document.cpp:
(WebCore::Document::deviceScaleFactor):
* dom/Document.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make it simpler to introduce new data types to the global object
https://bugs.webkit.org/show_bug.cgi?id=120801

Reviewed by Gavin Barraclough.

Add an iterator macro that lists all the "simple" ES types (e.g. type
consists of instance, constructor, and prototype classes).  So that
we don't need to have every new type litter JSGlobalObject.{cpp,h} with
members, accessors, and manual GC visiting.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Support SVG filters on -webkit-filter() function
https://bugs.webkit.org/show_bug.cgi?id=120806

Reviewed by Darin Adler.

Source/WebCore:

Add support for SVG Filters on CSS -webkit-filter() image function.

Test: fast/filter-image/filter-image-svg.html

* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image): Pass renderer to filter builder.

LayoutTests:

Test that the -webkit-filter() function can reference a SVG Filter
from the document.

* fast/filter-image/filter-image-svg-expected.html: Added.
* fast/filter-image/filter-image-svg.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Allow string as image reference on filter()
https://bugs.webkit.org/show_bug.cgi?id=120829

Reviewed by Andreas Kling.

Source/WebCore:

Beside <image> (which already includes url(), gradients, cross-fade() and
image-set()), the filter() image function should support <string> as image
reference.

http://dev.w3.org/fxtf/filters/#FilterCSSImageValue

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFilterImage): Create CSSImageValue from string.

LayoutTests:

Check that string can be used as image reference, that we
interpolate between the same images once referenced by string
and once by url() and that other tokens are not excepted.

* fast/filter-image/filter-image-animation-expected.txt:
* fast/filter-image/filter-image-animation.html:
* fast/filter-image/parse-filter-image-expected.txt:
* fast/filter-image/parse-filter-image.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix for the GTK port when building with FTL JIT enabled.

* GNUmakefile.list.am: Add the missing files to the build.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Grid Layout] Resolve named grid lines
https://bugs.webkit.org/show_bug.cgi?id=119632

Reviewed by Andreas Kling.

From Blink r152659, r153794 by <jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-named-grid-line-resolution.html

This change adds the code which translates from a raw named grid
line (stored in RenderStyle) to its actual grid position. This
even includes named grid resolution for grid lines with the 'span'
keyword.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::explicitGridSizeForSide):
(WebCore::adjustGridPositionForRowEndColumnEndSide):
(WebCore::adjustGridPositionForSide):
(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition):
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
* rendering/RenderGrid.h:

LayoutTests:

Added a new test to check named grid lines resolution. This also
provides some more new test cases with named grid lines and
negative positions.

* fast/css-grid-layout/grid-item-named-grid-line-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-named-grid-line-resolution.html: Added.
* fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt:
* fast/css-grid-layout/grid-item-negative-position-resolution.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Window used by WebKitTestRunner loses active status
https://bugs.webkit.org/show_bug.cgi?id=120774

Reviewed by Jocelyn Turcotte.

When focusing the PlatformWebView which is done at the start of each test, we should
ensure the host window of PlatformWebView is also made active, otherwise we will
not receive the keyboard events send by EventSenderProxy.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::focus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Cached credentials not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=120775

Reviewed by Jocelyn Turcotte.

Clear the access credentials when resetting the state of a page for testing.

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Unreviewed gardening. Update TestExpectations.

* platform/gtk-wk2/TestExpectations: Skip speech input tests, mark as failing drag and drop tests.
* platform/gtk-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
* platform/gtk-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
* platform/gtk/TestExpectations: Updated failing tests.
* platform/gtk/animations/cross-fade-background-image-expected.png: Removed.
* platform/gtk/animations/cross-fade-background-image-expected.txt: Removed.
* platform/gtk/editing/spelling/spellcheck-paste-expected.txt: Rebaseline after r154869.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening. Added missing results.

* platform/efl/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
* platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Added.
* platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Regions] Remove orphan test results
https://bugs.webkit.org/show_bug.cgi?id=120845

Patch by Radu Stavila <stavila@adobe.com> on 2013-09-06
Reviewed by Antti Koivisto.

Removed remaining orphan test results after https://bugs.webkit.org/show_bug.cgi?id=120760.

* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/qt-wk2/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
https://bugs.webkit.org/show_bug.cgi?id=120843

Reviewed by Csaba Osztrogonác.

Call notifyDone like the platform specific forceRepaintDoneCallback methods
it replaced did. The method is empty on the Apple ports.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::forceRepaintDoneCallback):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
https://bugs.webkit.org/show_bug.cgi?id=120847

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-06
Reviewed by Csaba Osztrogonác.

Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).

* WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::windowSnapshotEnabled):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpResults):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::windowSnapshotEnabled):
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155188 268f45cc-cd09-0410-ab3c-d52691b4dbfc