add constants and doc