Hello James,

I'm not sure what the naming conventions are for cocos. I was assuming the p stands for 'property'. Why should it be m_bSecureTextEntry? (I'd like to understand, so next time I can use proper conventions)

I do agree on your second point: isSecureTextEntry is probably better. Should I change this and create a new pull request? Or will you?

Grtz,

Marcel Bloemendaal.


On Apr 8, 2013, at 11:43 AM, James Chen <notifications@github.com> wrote:

> In cocos2dx/text_input_node/CCTextFieldTTF.h:
> 
> > @@ -145,6 +145,11 @@ class CC_DLL CCTextFieldTTF : public CCLabelTTF, public CCIMEDelegate
> >  protected:
> >      std::string * m_pPlaceHolder;
> >      ccColor3B m_ColorSpaceHolder;
> > +public:
> > +	virtual void setSecureTextEntry(bool value);
> > +	virtual bool getSecureTextEntry();
> > +protected:
> > +	bool m_pSecureTextEntry;
> Why to name this variable m_pSecureTextEntry?
> m_bSecureTextEntry will be more suitable.
> Also, the method getSecureTextEntry() should be isSecureTextEntry().
> 
> —
> Reply to this email directly or view it on GitHub.
>