i c it as 157-161.  have you actually tried it?
     // Temporarily store header class in variable
     $headerClass = htmlspecialchars($params->get('header_class'));

      // Create header class declaration
     $headerClass = !empty($headerClass) ? $moduleHeader . $headerClass 
. '"' : $moduleHeader.'"';

was written that was because as an amalgamation it would not function 
properly for me.

as to the if statement it is already there.. if (!empty ) means if it 
is, nothing will happen. which would be norm ergo skipping most of the 
code.  Makes no sense to call the var's inside of the if, as they 
wouldn't even be here if not for having the style active.
Bear

On 9/30/2013 09:17, Achal-Aggarwal wrote:
>
> In templates/system/html/modules.php:
>
> >
> >  	if (!empty ($module->content)) : ?>
> >  		<<?php echo $moduleTag; ?> class="moduletable<?php echo htmlspecialchars($params->get('moduleclass_sfx')); ?><?php echo $moduleClass; ?>">
> >
> >  		<?php if ((bool) $module->showtitle) :?>
> > -			<<?php echo $headerTag; ?> class="<?php echo $params->get('header_class'); ?>"><?php echo $module->title; ?></<?php echo $headerTag; ?>>
> > +			<<?php echo $headerTag . $headerClass . '>'?><?php echo $module->title; ?></<?php echo $headerTag; ?>>
>
> L39 can be rewritten as
>
> <<?php echo $headerTag . $headerClass; ?>><?php echo $module->title; 
> ?></<?php echo $headerTag; ?>>
>
> or even better (more clear version)
>
> <?php echo '<' . $headerTag . '>' . $module->title . '</' . $headerTag 
> . '>'; ?>
>
> Rest of the code looks great. :)
>
> one more thing if we can include lines L29 to L33 inside if block then 
> we can spare some clock cycles if $module->content is empty.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/joomla/joomla-cms/pull/2077/files#r6658419>.
>
> No virus found in this message.
> Checked by AVG - www.avg.com <http://www.avg.com>
> Version: 2014.0.4142 / Virus Database: 3604/6709 - Release Date: 09/29/13
>