Good call, totally slipped my mind.  On it's way...


On Thu, Mar 14, 2013 at 1:31 PM, Johan Oskarsson
<notifications@github.com>wrote:

> In zipkin-common/src/main/scala/com/twitter/zipkin/common/Endpoint.scala:
>
> > @@ -32,6 +35,25 @@ object Endpoint {
> >  case class Endpoint(ipv4: Int, port: Short, serviceName: String)
> >    extends Ordered[Endpoint] {
> >
> > +  /**
> > +   * Return the java.net.InetSocketAddress which contains host/port
> > +   */
> > +  def getInetSocketAddress: InetSocketAddress = {
>
> Forgot one thing in the last review: would be nice with some quick tests
> for these new methods too
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/zipkin/pull/235/files#r3381053>
> .
>