I just imported one of the courses whose tabs were failing to load, into
the current master, and the tabs came up fine.  The tabs came up fine also
when I changed this line to

                    tab['name'] = metadata.get('display_name')

However, if I use this line in an instance of edx-platform circa
10-aug-2013, then the tabs show up as "None".

So it appears something else has been fixed, which alleviates this tabs
naming issue.


On Mon, Sep 9, 2013 at 4:06 PM, chrisndodge <notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/modulestore/mongo/base.py:
>
> > @@ -794,7 +794,7 @@ def update_metadata(self, location, metadata):
> >              existing_tabs = course.tabs or []
> >              for tab in existing_tabs:
> >                  if tab.get('url_slug') == loc.name:
> > -                    tab['name'] = tab.get('name', metadata.get('display_name'))
>
> @ichuang <https://github.com/ichuang> do you happen to have a sample
> course (or course snippet) which illustrated this behavior. This will help
> me to make a unit test to help assert correct behavior.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/882/files#r6249248>
> .
>