more work on popups