Allow constructor arguments.
Document symfony/twig-bridge requirement for forms in twig templates
merged branch igorw/form-twig-bridge-doc (PR #561)

This PR was merged into the master branch.

Commits
-------

332142f Document symfony/twig-bridge requirement for forms in twig templates

Discussion
----------

Document symfony/twig-bridge requirement for forms in twig templates
Rename ErrorHandlerTest to ExceptionHandlerTest
[docs] Add cookbook recipe for the ErrorHandler
merged branch igorw/rename-error-handler-test-to-exception-handler (PR #562)

This PR was merged into the master branch.

Commits
-------

d2c42b3 Rename ErrorHandlerTest to ExceptionHandlerTest

Discussion
----------

Rename ErrorHandlerTest to ExceptionHandlerTest
Replace double colons with valid PHP syntax
merged branch CHH/patch-1 (PR #564)

This PR was merged into the master branch.

Commits
-------

490dd92 Replace double colons with valid PHP syntax

Discussion
----------

Replace double colons with valid PHP syntax
Test session service provider with routes that does not use session
merged branch romainneutron/Sessions (PR #565)

This PR was squashed before being merged into the master branch (closes #565).

Commits
-------

55dce6b Test session service provider with routes that does not use session

Discussion
----------

Test session service provider with routes that does not use session

Hello,

Since symfony/Symfony@098b593591, a bug occurs with `SessionServiceProvider` :

When using `HttpKernel\Client`, setting `$app['session.test'] = true;` and querying the application multiple routes in a single unit test, a `RuntimeException` is thrown by `Symfony\Component\HttpFoundation\Session\Storage\MockFileSessionStorage`.

For instance :

```php
use Silex\WebTestCase;
use Silex\Application;
use Silex\Provider\SessionServiceProvider;

class unitTest extends WebTestCase
{
    public function testUn()
    {
        $client = $this->createClient();
        $client->request('GET', '/');
        $client->request('GET', '/');
    }

    public function createApplication()
    {
        $app = new Application();

        $app->register(new SessionServiceProvider(), array(
            'session.test' => true
        ));

        $app['debug'] = true;
        $app['exception_handler']->disable();

        $app->get('/', function(Application $app) {
            return 'BOOM';
        });

        return $app;
    }
}
```
results in
```
1) unitTest::testUn
RuntimeException: Trying to save a session that was not started yet or was already closed

/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/Session/Storage/MockFileSessionStorage.php:101
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/Session/Session.php:184
/Users/romain/Documents/workspace/testSess/vendor/silex/silex/src/Silex/Provider/SessionServiceProvider.php:107
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php:164
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php:53
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:169
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:151
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:73
/Users/romain/Documents/workspace/testSess/vendor/silex/silex/src/Silex/Application.php:469
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Client.php:61
/Users/romain/Documents/workspace/testSess/vendor/symfony/symfony/src/Symfony/Component/BrowserKit/Client.php:264
/Users/romain/Documents/workspace/testSess/bingo.php:13
```

Of course, this test currently passes as the bug happens with latest `2.1.x-dev` source whereas `composer.json` settings ask to install latest stable tag.

This PR adds a test that fails with latest symfony 2.1.x.

---------------------------------------------------------------------------

by romainneutron at 2012-12-17T22:19:24Z

It seems the fix I've added is good enough, so, finally this PR brings a solution to the problem :)
add charset documentation in doctrine provider
merged branch ricardclau/add_charset_doc_doctrineprovider (PR #569)

This PR was merged into the master branch.

Commits
-------

d32857a add charset documentation in doctrine provider

Discussion
----------

[docs] Add charset documentation in doctrine provider

This PR refers to https://github.com/fabpot/Silex/issues/549 and adds documentation on how to setup charset when connecting to mysql

I've also edited the mysql example so that it is even more clear

And last but not least, I've upgraded links to doctrine documentation so that it points to their latest version

---------------------------------------------------------------------------

by ricardclau at 2012-12-30T14:31:32Z

Tests have failed in travis due to a TransportException when downloading Pimple... weird!
Update src/Silex/Application.php

EventDispatcher addListener function has no return value
merged branch janschoenherr/patch-1 (PR #571)

This PR was merged into the master branch.

Commits
-------

6b248b0 Update src/Silex/Application.php

Discussion
----------

Update src/Silex/Application.php

EventDispatcher addListener function has no return value

---------------------------------------------------------------------------

by GromNaN at 2013-01-02T15:45:08Z

Exact.
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/EventDispatcher/EventDispatcher.php#L88
renamed a chapter (closes #570)
adding missing reference to the serializer doc page
merged branch igorw/error-handler-cookbook (PR #563)

This PR was merged into the master branch.

Commits
-------

d272d71 [docs] Add cookbook recipe for the ErrorHandler

Discussion
----------

[docs] Add cookbook recipe for the ErrorHandler

---------------------------------------------------------------------------

by igorw at 2013-01-03T00:46:52Z

bump.

---------------------------------------------------------------------------

by davedevelopment at 2013-01-03T01:02:13Z

:+1:  looks good
merged branch marijn/feature/constructor-parameters (PR #556)

This PR was merged into the master branch.

Commits
-------

6543379 Allow constructor arguments.

Discussion
----------

Allow constructor arguments.

Unfortunately my phpunit installation is horribly broken so I can't run the tests right now...

---------------------------------------------------------------------------

by igorw at 2012-11-27T00:21:38Z

:+1:

---------------------------------------------------------------------------

by igorw at 2012-11-27T00:21:49Z

Docs?

---------------------------------------------------------------------------

by igorw at 2012-11-27T00:24:24Z

The parent constructor should probably be called at the end, that allows parameters to override the default services. And you should add a test case for that too.

---------------------------------------------------------------------------

by GromNaN at 2012-11-27T07:54:31Z

@igorw The parent constructor replaces everything, so it cannot be called at the end.
https://github.com/fabpot/Pimple/blob/master/lib/Pimple.php#L46

---------------------------------------------------------------------------

by fabpot at 2013-01-03T08:10:28Z

What about just calling `array_replace($this->values, $values)` at the end of the constructor instead?

---------------------------------------------------------------------------

by igorw at 2013-01-03T08:35:02Z

Sounds good to me.
allowed to override application values via the constructor
Call parent constructor in app, to initialize pimple