That works for me, I didn't like modifying the existing public API.

On Jul 16, 2013, at 4:06 PM, Hoà V. DINH <notifications@github.com> wrote:

> In src/core/imap/MCIMAPSession.h:
> 
> > @@ -88,9 +88,11 @@
> >          virtual void expunge(String * folder, ErrorCode * pError);
> >          
> >          virtual Array * /* IMAPMessage */ fetchMessagesByUID(String * folder, IMAPMessagesRequestKind requestKind,
> It's breaking the APIs and additionally, ErrorCode was supposed to be at the end of the parameters. You're breaking this "rule".
> I'd rather add a fetchMessageByUIDWithExtraHeaders() method since it won't be the common case to use those methods.
> 
> —
> Reply to this email directly or view it on GitHub.
>