Hey John,
A couple of reasons.
It's just a convention many people follow , that every if else block must
end in an else. Also here I am addressing a completely
different logical decisions. one determines paused and stopped states and
sets the telepathy presence type to away.  The second if block just ignores
changes on adverts . I like to keep the logical blocks separate for that
reason . Just more clear. The performance impacts are zilch anyway , this
just makes it easier . If i wanted to introduce code to mute audio on the
system during an advert i could add it there. (Probably coming soon).
If you feel strongly about the same i could implement that way.
Cheers !

Final Yr Undergraduate , BITS Pilani, Goa.
Research Assistant , RoboEarth Project
Institute for Dynamic Systems and Control,
ETH Zürich, Switzerland.
dhananjaysathe@gmail.com |  f2009260@goa.bits-pilani.ac.in | +91
976-487-1950


On Mon, Jan 28, 2013 at 10:48 PM, John Reese <notifications@github.com>wrote:

> In bin/spotify:
>
> > @@ -171,11 +171,12 @@ class SpotifyGnome(object):
> >          self.notification.update(title, body, icon)
> >          self.notification.show()
> >          status = "♫ ".decode('utf8')+status_content+" ♫".decode('utf8')
> > -        if ENABLE_TELEPATHY:
> > -	        if self.telepathy_away :
> > -	            self.telepathy_accn_manager.set_all_requested_presences(telepathy.ConnectionPresenceType.AWAY,'away', status)
> > -	        else:
> > -	            self.telepathy_accn_manager.set_all_requested_presences(telepathy.ConnectionPresenceType.AVAILABLE,'available', status)
> > +        if ENABLE_TELEPATHY :
> > +            if self.telepathy_away :
> > +                self.telepathy_accn_manager.set_all_requested_presences(telepathy.ConnectionPresenceType.AWAY,'away', status)
> > +            else:
>
> Is there a reason to not combine 177 and 178 into a single elif?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jreese/spotify-gnome/pull/7/files#r2800288>.
>
>