Yeah, I'm not sure what behavior is reasonable for the case when it's None,
which is why I'm not being more of a stinker about it. But catching the
TypeError and doing something sensible would make me feel all warm and
comfy.


On Fri, Sep 20, 2013 at 1:32 PM, Vik Paruchuri <notifications@github.com>wrote:

> In
> common/lib/xmodule/xmodule/open_ended_grading_classes/self_assessment_module.py:
>
> > @@ -218,7 +214,7 @@ def save_assessment(self, data, _system):
> >              return self.out_of_sync_error(data)
> >
> >          try:
> > -            score = int(data['assessment'])
> > +            score = int(data.get('assessment'))
>
> @nedbat <https://github.com/nedbat> Has been upset at me before for
> specifying a default of None, so I will let you two argue that one out :) .
>
> I don't mind catching the typeerror if that would help.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/1068/files#r6497157>
> .
>