engine: Improve message when network is mis-configured

The patch adds a specific message to the host general sub tab
for the case of a VM network isn't implemented so on the host.

In addition, it adjusts the indicator of the same error in the
event log to warning so it could be noticeable easily.

Change-Id: I0f51fdc0d66cc55020858391dabd026b88e4fe35
Bug-Url: https://bugzilla.redhat.com/951920
Signed-off-by: Moti Asayag <masayag@redhat.com>
packaging: engine-upgrade - log DB upgrade in the right place

DB Upgrade script should be run with the wanted log location, otherwise,
it creates the upgrade log in the dbscripts directory (currently, in
/usr/share)

Change-Id: I15cb1e0d7ce12a27ae07c92025db6b21636957c9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947344
Signed-off-by: Ofer Schreiber <oschreib@redhat.com>
webadmin: Host General sub-tab  unlocalized strings found

changes are described in bugzilla.

Change-Id: I59b0ba281c912d1a9e09b9ab3dde1be93b0c7e56
Bug-Url: https://bugzilla.redhat.com/952091
Signed-off-by: Gilad Chaplik <gchaplik@redhat.com>
webadmin: truncated text in Storage main-tab

Fixed truncated headers in Storage main-tab.

Change-Id: I31820f0820767cd993b21c57711b25a310706d97
Bug-Url: https://bugzilla.redhat.com/950019
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: truncated text in VMs-Disks sub-tab

Fixed truncated headers VMs -> Disks sub-tab.

Change-Id: I2e9c4853bdd6da18801be7c04a0c201331afb7a4
Bug-Url: https://bugzilla.redhat.com/952457
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: truncated text in Disks main-tab

Fixed truncated headers in Disks main-tab.

Change-Id: I2d8a8e939e4f1b09ff880a559da7899d56cd036d
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: truncated text in VMs-Snapshots sub-tab

Fixed truncated headers in VMs -> Snapshots sub-tab.

Change-Id: I2e9586f77343645a74727452e58052c8b659e5fc
Bug-Url: https://bugzilla.redhat.com/951067
Bug-Url: https://bugzilla.redhat.com/950289
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: truncated text in Storage-Disks sub-tab

Fixed truncated headers in Storage -> Disks sub-tab.

Change-Id: I4adca437d72c8abb75f47a15bb14536d3b5d2c4d
Bug-Url: https://bugzilla.redhat.com/922731
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: Networks General sub-tab- Role section has misplaced comma

Items listed on the right of "Role" has an odd space before comma.
The space should be after the comma.

Change-Id: I19cc13aff4a2bf9d2e6c97e282a6fc6103bb12e8
Bug-Url: https://bugzilla.redhat.com/949759
Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
webadmin: invoke event dialog from sub-tabs

Display event dialog on double-click (or right-click -> Details)
an event in Events sub-tabs.

Change-Id: I88c2ddbfc8db4e4bd476bb5e1a595274197c2a55
Signed-off-by: Daniel Erez <derez@redhat.com>
webadmin: Improved sorting in Setup Networks sub menu

Items are now sorted "lexoNumerically" rather than lexicographically.

Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783
Signed-off-by: Lior Vernia <lvernia@redhat.com>
userportal: resources->quota updating

- Fixed resources quota class cast exception causing
quota not to update.

Change-Id: Iefbbd93e407f40070bf187557560fb2f73a41c0b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928967
Signed-off-by: Alexander Wels <awels@redhat.com>
restapi: Don't mandate a network when adding a template NIC

In template context, it should be possible to add a NIC even
without the network id/name since the network unlinking feature was
pushed.

The backend will know to fail the action if an empty network is sent and
the feature is unsupported.

Change-Id: Id5b1953178f4ff5e04a71688d8ccec5d3c789395
Bug-Url: https://bugzilla.redhat.com/952647
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
findbugs: When implementing compareTo implement Object.equals as well

Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
webadmin: wrong quota(s) in dc-quota subtab

Caused by a call to super.syncSearch(), which created a
wrong (another) query to server.

Change-Id: I3f9f347b15633ab1e8215a45816c7aba1149252b
Bug-Url: https://bugzilla.redhat.com/950536
Signed-off-by: Gilad Chaplik <gchaplik@redhat.com>
core: use DiskImage.copyOf in getAllDisks query

GetAllDisksByStorageDomainIdQuery:
add a copy of the active DiskImage to snapshots list
[adding it as is causes infinte recursion in DiskImage->hashCode()]

Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0
Bug-Url: https://bugzilla.redhat.com/951909
Signed-off-by: Daniel Erez <derez@redhat.com>
spelling: s/clsuter/cluster

Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f
Signed-off-by: Itamar Heim <iheim@redhat.com>
core: Remove unused ImagesHandlerActionParameters

Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove checkImagesLocked(vmId, messages)

Removed ImagesHandler.checkImagesLocked(Guid vmId, List<String
messages), as ImagesHandler should not know about VMs.

Wherever it was used (two places - AddVmFromSnapshot and
LiveMigrateVmDisks), it was replaced with a direct call to DiskDao and
then a simpler call to
ImagesHandler.checkImagesLocked (messages, disks).

Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove image status check from ImagesHandler

Extracted all image status checks from ImagesHandler and moved them to
the new DiskImagesValidator class, as a step in the effort to decouple
ImagesHandler.PerformImagesChecks.

Change-Id: I7c26d6cf37227aded9318523f0a807e19eeaa7bc
Signed-off-by: Allon Mureinik <amureini@redhat.com>