classify some traits
Merge pull request #523 from xuwei-k/classify

classify some traits