Makes sense. I agree with the sentiment, but I think one extra method in
the name of clarity is probably worth it.


-Mat

about.me/matschaffer


On Thu, Apr 4, 2013 at 7:51 AM, Teemu Matilainen
<notifications@github.com>wrote:

> In lib/chef/knife/bootstrap_solo.rb:
>
> > +  class Knife
> > +    class Bootstrap
> > +
> > +      def self.load_deps
> > +        super
> > +        require 'chef/knife/solo_bootstrap'
> > +        require 'knife-solo/tools'
> > +        SoloBootstrap.load_deps
> > +      end
> > +
> > +      option :solo,
> > +        :long        => '--[no-]solo',
> > +        :description => 'Bootstrap using knife-solo'
> > +
> > +      # Rename and override run method
> > +      alias_method :orig_run, :run
>
> Roger. Originally I was using another method but then after the line count
> had reduced (while knife-solo gained more and more compatibility), I put
> all back to run not to pollute Knife::Bootstrap's namespace. But I don't
> think the risk for collision is significative here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/matschaffer/knife-solo/pull/207/files#r3653608>
> .
>