<https://webkit.org/b/120017> Remove NodeRenderingTraversal::ParentDetails

Reviewed by Andreas Kling.

Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
        
Also removed support for reset-style-inheritance attribute in InsertionPoint. We don't use or expose it.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleForElement):
* css/StyleResolver.h:
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::elementLinkState):
        
    Remove m_distributedToInsertionPoint State field. We never hit the cases where it was used.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::traverseParent):
        
    Return null instead of setting childWasOutOfComposition to details object. That's what would happen anyway in the caller.

(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
* dom/ComposedShadowTreeWalker.h:
* dom/Node.cpp:
(WebCore::Node::insertionParentForBinding):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
        
    Make this look up InsertionPoint directly intead of relying it being populated in m_parentDetails. The function is used only in
    a few non-performance critical places.

(WebCore::NodeRenderingContext::resetStyleInheritance):
        
    Return parent ShadowRoots resetStyleInheritance() flag instead of using m_parentDetails.

* dom/NodeRenderingContext.h:
* dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::parentSlow):
* dom/NodeRenderingTraversal.h:
(WebCore::NodeRenderingTraversal::parent):
        
    Remove ParentDetails.

* html/HTMLAttributeNames.in:
* html/shadow/InsertionPoint.cpp:
        
    Remove unused resetStyleInheritance attribute.

(WebCore::InsertionPoint::removedFrom):
(WebCore::findInsertionPointOf):
        
    Renamed for clarity.

* html/shadow/InsertionPoint.h:
* testing/Internals.cpp:
(WebCore::Internals::includerFor):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings

Reviewed by Martin Robinson.

Source/WebCore:

No new tests, these are just stubs for the DOM bindings API.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
* bindings/gobject/WebKitDOMCustom.h:

Tools:

* Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
from naming/enum_casing rules, since it needs to provide GObject-style APIs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<https://webkit.org/b/119487> [Gtk] Cancel authentication on load failed

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-20
Reviewed by Martin Robinson.

Added callback to handle load-failed event in default authentication dialog.
Authentication request gets cancelled and the dialog widget gets destroyed.

* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(pageLoadFailed):
(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogDispose):
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew):
* UIProcess/API/gtk/WebKitAuthenticationDialog.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewAuthenticate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Avoid an assertion from calling releaseBufferDrawable(nullptr)
https://bugs.webkit.org/show_bug.cgi?id=119862
JIRA 470760

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-08-20
Reviewed by Antonio Gomes.

destroyBuffer() finds a null pointer valid but
releaseBufferDrawable() does not. Fix by adding a
null pointer check.

No new tests, caught by existing layout test runs.

* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::~ImageBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove a string no longer used after r154251.

Rubber-stamped by Brady Eidson.

* English.lproj/Localizable.strings:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<https://webkit.org/b/120032> Add DRT test to ensure that AccessibilityObject::stringValue()
of <input type="file"> is meaningful

Reviewed by Chris Fleizach.

Adds a DRT test to ensure that AccessibilityObject::stringValue() returns a meaningful string
for a single file- and multiple files-file upload control.

* accessibility/file-upload-button-stringvalue.html: Added.
* platform/mac-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.
* platform/mac/accessibility/file-upload-button-stringvalue-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use PlatformArchitecture to distinguish between 32-bit and 64-bit builds on Windows.
https://bugs.webkit.org/show_bug.cgi?id=119512

Reviewed by Brent Fulgham.

Source/JavaScriptCore: 

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
* JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
Replaced obj32, bin32, and lib32 with macros for 64-bit build.

Source/ThirdParty: 

* gtest/msvc/gtest-md.vcxproj:
Replaced obj32, bin32, and lib32 with macros for 64-bit build.

Source/WebCore: 

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.vcxproj/WebCoreCommon.props:
* WebCore.vcxproj/WebCoreGeneratedCommon.props:
* WebCore.vcxproj/WebCoreTestSupport.vcxproj:
* WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
Replaced obj32, bin32, and lib32 with macros for 64-bit build.

Source/WebKit: 

* WebKit.vcxproj/Interfaces/InterfacesCommon.props:
* WebKit.vcxproj/WebKit/WebKit.vcxproj:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
* WebKit.vcxproj/WebKit/WebKitCommon.props:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
* WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props:
Replaced obj32, bin32, and lib32 with macros for 64-bit build.

Source/WTF: 

* WTF.vcxproj/WTFGeneratedCommon.props:
Replaced obj32, bin32, and lib32 with macros for 64-bit build.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=120052
Remove custom getOwnPropertyDescriptor for JSProxy

Reviewed by Geoff Garen.

GET_OWN_PROPERTY_DESCRIPTOR_IMPL runs afoul with JSProxy due to the workaround for JSDOMWindow's broken behavior.
Because the window object incorrectly searches the prototype chain in getOwnPropertySlot we check that the base
object matches, but in the case of JSProxy we can end up comparing the window object to the window shell & falsely
assuming this is a prototype property. Add toThis conversion to correctly identify proxied own access. I've kept
the original slotBase check as a fast case, and also so that direct access on JSDOMWindow still works.

* runtime/JSProxy.cpp:
    - Remove custom getOwnPropertyDescriptor implementation.
* runtime/PropertyDescriptor.h:
    - Modify own property access check to perform toThis conversion.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=120053
Remove custom getOwnPropertyDescriptor for JSNPObject

Reviewed by Oliver Hunt.

Think this is the last one!

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
    - Remove custom getOwnPropertyDescriptor implementation.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=120054
Remove some dead code following getOwnPropertyDescriptor cleanup

Reviewed by Oliver Hunt.

../JavaScriptCore: 

* runtime/Lookup.h:
(JSC::getStaticFunctionSlot):
    - remove getStaticPropertyDescriptor, getStaticFunctionDescriptor, getStaticValueDescriptor.

../WebCore: 

* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/JSPluginElementFunctions.h:
    - remove runtimeObjectCustomGetOwnPropertyDescriptor, pluginElementCustomGetOwnPropertyDescriptor



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=120067
Remove getPropertyDescriptor

Reviewed by Oliver Hunt.

This is used by lookupGetter/lookupSetter - this can easily bee replaced by getPropertySlot.
Since we'll be getting the GetterSetter from the slot in the setter case, rename isGetter() to isAccessor().

* runtime/JSObject.cpp:
* runtime/JSObject.h:
    - remove getPropertyDescriptor
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
    - replace call to getPropertyDescriptor with getPropertySlot
* runtime/PropertyDescriptor.h:
* runtime/PropertySlot.h:
(JSC::PropertySlot::isAccessor):
(JSC::PropertySlot::isCacheableGetter):
(JSC::PropertySlot::getterSetter):
    - rename isGetter() to isAccessor()



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[css3-text] Implement CSS3 text-decoration shorthand
https://bugs.webkit.org/show_bug.cgi?id=92000

Implements the text-decoration shorthand (with -webkit- prefix), as specified by the CSS3 Text Decoration specification:
http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-property

Backported from Blink:
https://src.chromium.org/viewvc/blink?revision=156266&view=revision

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<https://webkit.org/b/119914> [iOS] Upstream changes to WebCore/accessibility

Reviewed by Darin Adler and Chris Fleizach.

* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::press):
(WebCore::AccessibilityMenuList::isCollapsed):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::headingElementForNode):
(WebCore::AccessibilityObject::actionVerb):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::actionVerb):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154339 268f45cc-cd09-0410-ab3c-d52691b4dbfc