Add flavor-access to core for V3 API

Adds the flavor-access plugin to the core list for the V3 API.
This is part of the process of adding all of the flavor related
extensions to core, with the exception of rxtx, as per the discussion
here: https://etherpad.openstack.org/p/NovaV3APICore

Note that since the alias changes from os-flavor-access to flavor-access
the api samples move directory and quite a few of other api samples
as well as flavor access is included by default.

Partially implements blueprint nova-v3-api

DocImpact

Change-Id: I9abc7df8f4620d462b0d381a2c0ed180c48f220e
Add flavor-extra-specs to core for V3 API

Adds the flavor-extra-specs plugin to the core list for the V3 API.
This is part of the process of adding all of the flavor related
extensions to core, with the exception of rxtx, as per the discussion
here: https://etherpad.openstack.org/p/NovaV3APICore

Partially implements blueprint nova-v3-api

Change-Id: Id4b4fad5e584bdf2bbbaaae579a07e28c312ef34
Remove V3 API version of coverage extension

As discussed at the summit in the QA session, this removes
the coverage extension from the V3 API. The coverage extension
doesn't work properly and has security issues. An alternative technique,
though more limited in nature will soon be proposed.

Partially implements blueprint nova-v3-api

Change-Id: Ib4296288fefeb7e1e11bb6e44bd1cf355f29b9b9
Remove V2 API version of coverage extensions

As discussed at the summit in the QA stream, this removes
the coverage extension from the V2 API.

According to the API Change Guidelines
https://wiki.openstack.org/wiki/APIChangeGuidelines
we should not be doing this. However the coverage
extension is a rather special case. It has security issues
such that it shouldn't be used in a production cloud
environment. It also doesn't work properly so its usefulness
to measure API coverage is limited. And in the past the presence of
this plugin has been used as a reason not to accept
an alternative technique to measure API coverage.

This is the proposed replacement

https://review.openstack.org/#/c/25882/

Change-Id: I07d798129ee277a6f7691c25f88c07a5204c0943
Move flags in libvirt's volume to the libvirt group

This change continues moving libvirt specific flags into a libvirt
specific configuration group.

Progresses blueprint libvirt-opts-group.

DocImpact: the following flags have moved into the libvirt group:
    num_iscsi_scan_tries
    num_iser_scan_tries
    rbd_user
    rbd_secret_uuid
    nfs_mount_point_base
    nfs_mount_options
    num_aoe_discover_tries
    glusterfs_mount_point_base
    iscsi_use_multipath (formerly libvirt_iscsi_use_multipath)
    iser_use_multipath (formerly libvirt_iser_use_multipath)
    scality_sofs_config
    scality_sofs_mount_point
    qemu_allowed_storage_drivers

Change-Id: I78941aff4bf49fc70d91a3239deff44dbaaab6c9
Recover from build state on compute manager start-up

If a compute manager is stopped / fails during a build operation
then the instance will be left stuck with vm_state=BUILDING

During restart the one thing we can be sure about such instances
is that providing the task state is not SCHEDULING (i.e the request
is not still on the queue) then there is no thread running for this
instance.

In this case we can treat instances in this state as if they have
failed to spawn and put the into an ERROR state.

Closes-Bug: 1197024
Related to blueprint recover-stuck-state

Change-Id: I7b116d8154036c43b0feb23f5669f52358408d2b
Don't overwrite marker when checking if it exists

Checking for the existence of a marker overwrote which marker was being
checked for.  The string representation of the marker needs to be
retained so that a proper exception can be built.  So a new variable is
introduced which can be used to check for marker existence.

Change-Id: I81cfdceca3921c364cdeeccd24add14a6b1d0fd4
Closes-bug: 1257008
docker: access system_metadata as a dict

This bit of code causes a problem when moving to objects.  The Instance
object presents system_metadata as you would normally expect (a dict).
The data is in a different format when working with a db instance.  Use
the handy helper utility to normalize it into a dict.

Change-Id: Ieca9ab449a07374ed2c9cdaffdfd54783df7a866
Merge "Don't overwrite marker when checking if it exists"
Merge "Remove V3 API version of coverage extension"
Merge "Remove V2 API version of coverage extensions"
Merge "Recover from build state on compute manager start-up"
Merge "docker: access system_metadata as a dict"
Merge "Add flavor-access to core for V3 API"
Merge "Add flavor-extra-specs to core for V3 API"
Merge "Move flags in libvirt's volume to the libvirt group"