fix functino signature