Added padding to 4 bytes to network filehandles.
This will allow dNFS to function because it does not do the padding itself.
Don't check timestamp or length in creds when comparing v4 clientid verifiier

Clients create new creds so timestamp is a problem.

New creds might have a different group list, which changes length of cred, if
we don't care about group list, shouldn't care about cred length either.

Signed-off-by: Frank Filz <ffilz@us.ibm.com>
Fix value of DRC_FLAG_RELEASE

Signed-off-by: Adam C. Emerson <aemerson@linuxbox.com>
Remove --enable-snmp-adm from config options

Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
Fix negative reviews.

Header merge fix for syren fix 81024326.

Signed-off-by: Matt Cleveland <mgclevel@us.ibm.com>
If lookup fails and error is not CACHE_INODE_NOT_FOUND, return
immediately.

Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
Signed-off-by: rong zeng <rongzeng@us.ibm.com>
Don't destroy UDP transports on reply error

Signed-off-by: Adam C. Emerson <aemerson@linuxbox.com>
Bring in two fixes in tirpc for UDP recvmsg handling.

Signed-off-by: rong zeng <rongzeng@us.ibm.com>
Clean up use of NFS4ERR_BADHANDLE vs NFS4ERR_STALE

A handle that COULD be a valid Ganesha handle, that happens to not be
valid currently (for example, exportid doesn't reference a currently
valid export), or a PseudoFS ID that is in range, but not currently
valid should result in NFS4ERR_STALE.

NFS4ERR_BADHANDLE should be reserved for handles that are badly formed
or otherwise could not ever be a valid Ganesha handle. We also more
carefullly check handle validity, and make checks in order such that
there won't be any surprises, like indexing beyond end of provided
handle.

We must also properly validate PseudoFS handles by the same criteria.

NFS v3 and NLM validate handles during nfs_rpc_execute. If the handle
is bad or the exportid is bad, an SVC AUTH error was sent. This is
wrong, we must send NFS3ERR_BADHANDLE for bad handles and
NFS4ERR_STALE for invalid exportid. Because NLM has ASYNC procedures,
we allow a NULL pexport to be passed to NLM procedures that take
handles, and let the procedure handle responding. NFS procedures will
be responded to within nfs_rpc_execute.

Additionally, remove CACHE_INODE_UNAPPROPRIATED_KEY and
STATE_UNAPPROPRIATED_KEY since these errors are never used (and
were translated into NFS4ERR_BADHANDLE which is probably not the right
error if we ever did have that return code.

Several handle validation routines return an NFS4ERR, we now use the
returned value in most cases (except for RESTOREFH which has a specific
error code to report empty SavedFH.

Added nfs4_sanity_check_SavedFH to simplify checking of SavedFH and
remove duplicate code.

Fix PUBFH. We were not setting the length of it, so it was taking
maximum length and this was not equal to ROOTFH. The length of a
PseudoFS handle is also now computed the same way a normal handle
length is computed.

NFS v2/v3 LINK and RENAME operations should properly validate
the destination directory handle and properly report errors.

Clean up how handle errors are logged. LogInfo is used so that
sysadmins can debug handle issues without having to see gory
code internals.

Replace nfs4_sprint_fhandle with sprint_fhandle4 (remove duplicate
code).

Replace print_buff with new routine print_fhandle_fsal for FSAL handles
to be more informative.

Signed-off-by: Frank S. Filz <ffilz@us.ibm.com>