pyflakes is actually smart, if it sees __all__ = ['foo'] it knows foo is
used.


On Fri, Nov 1, 2013 at 10:26 AM, Daniel Farina <notifications@github.com>wrote:

> In wal_e/blobstore/s3/__init__.py:
>
> > @@ -0,0 +1,9 @@
> > +from wal_e.blobstore.s3.s3_util import uri_put_file
> > +from wal_e.blobstore.s3.s3_util import do_lzop_get
> > +from wal_e.blobstore.s3.s3_util import write_and_return_error
> > +
> > +__all__ = [
> > +    uri_put_file,
> > +    do_lzop_get,
> > +    write_and_return_error,
>
> On Fri, Nov 1, 2013 at 10:24 AM, Alex Gaynor <notifications@github.com
> >wrote:
>  In wal_e/blobstore/s3/__init__.py: > @@ -0,0 +1,9 @@ > +from
> wal_e.blobstore.s3.s3_util import uri_put_file > +from
> wal_e.blobstore.s3.s3_util import do_lzop_get > +from
> wal_e.blobstore.s3.s3_util import write_and_return_error > + > +__all__ = [
> > + uri_put_file, > + do_lzop_get, > + write_and_return_error, __all__ is
> supposed to be a list of names, not a list of funciton objects.
> Orly. I was abusing it to shut up pyflakes. So let's get rid of it but
> find some other way, since strings won't help and presumably that's for
> dynamic message behavior. Suggestions?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wal-e/wal-e/pull/47/files#r7375343>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084