not a real api, so i think its fine to change. our clients don't rely on
that.


On Fri, Dec 6, 2013 at 4:38 PM, Manoj Cheenath <notifications@github.com>wrote:

> In src/main/java/com/twitter/joauth/Unpacker.java:
>
> > +        Request.ParsedRequest parsedRequest = request.parsedRequest(oAuthParamsBuilder.otherParams());
> > +
> > +        if (oAuthParamsBuilder.isOAuth2()) {
> > +          return getOAuth2Request(request, parsedRequest, oAuthParamsBuilder.oAuth2Token());
> > +        } else if (oAuthParamsBuilder.isOAuth1()) {
> > +          return getOAuth1Request(parsedRequest, oAuthParamsBuilder.oAuth1Params());
> > +        } else if (oAuthParamsBuilder.isOAuth1TwoLegged()) {
> > +          return getOAuth1TwoLeggedRequest(parsedRequest, oAuthParamsBuilder.oAuth1Params());
> > +        } else {
> > +          return new UnpackedRequest.UnknownRequest(parsedRequest);
> > +        }
> > +
> > +      } catch (UnpackerException u) {
> > +        throw u;
> > +      } catch (Throwable t) {
> > +        t.printStackTrace(); //TODO: log instead?
>
> it was printing the stack trace to console before. I was not sure if
> someone depends on that output.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/joauth/pull/22/files#r8178933>
> .
>



-- 
Kevin Oliver | Twitter, Inc | follow me: @kevino <http://twitter.com/kevino>