(#2437) Renaming the spec test case constants

The constants in the spec now have a name that tries to
indicate what is tested. Previous naming was not
explicit.
(#2437) Use interpolation instead of string concatenation

Following a comment on pull request #1924
(#2437) Convert case statement on boolean to if/else (1/2)

For the @invar boolean variable, following comment on pull
request #1924
(#2437) Convert case statement on boolean to if/else (2/2)

For the @inobject boolean variable, following comment on pull
request #1924. Also removed some dead code and fixed comments.
(#2437) Split logic into methods to lower complexity

The case statement is pretty deep and hard to follow.
Also corrected 2 other occurrences of string concatenation.
(#2437) Split logic into methods to lower complexity (continued)

Also renamed internal state variables to be more explicit
Merge remote-tracking branch 'kylo/issue/22522-facts-api-doc'

* kylo/issue/22522-facts-api-doc:
  (#22522) Use :nodename instead of :name in URIs
  (#22522) some formatting fixups
  (#22522) validate node facts against facts schema
  (#22522) mark the 4 fields in the facts schema as required
  (#22522) add documentation for facts endpoints
  (#22522) rename catalog_facts.json -> facts.json

Conflicts:
	api/docs/http_api_index.md

Resolved conflict in table of contents.
(#22458) Always store the path for launchd service provider

Otherwise the path won't be found next time the provider is asked for it
Merge branch 'pull-1883'

This closes GH-1883
Merge pull request #1917 from mihau/patch-1

Add missing newline in sendmail usage to tagmail
(doc) Mark some of the Provider API public
Merge pull request #1913 from zaphod42/issue/master/21198-missing-vars-in-data-bindings

(#21198) Allow data bindings w/ hiera to get special vars
Merge pull request #1927 from jjulien/iss7911

(#7911) Fixed exception when using forcelocal param
Merge pull request #1937 from zaphod42/maint/master/cleanup-examples-dir

(Maint) Documentation fixes
(maint) rename urpmi spec to be run by default
(#2437) Remove action method

Remove noop method
(#2437) remove bloc comments

It seems bloc comment do not really exist in ruby. Replaced
them with line comments.
(#2437) fix case statements indent

Align case and when at the same level
(#2437) convert to two space tabs

Reformating code to use 2 space tabs.
(maint) reduce duplication of logdest option handling

Prior to this commit there were 6 different puppet applications
with independent implementaions handling the `--logdest` option,
including two that were logging directly to stderr rather than
using `Puppet.log_exception` helper. This commit pulls those
implementations up into Puppet::Application and unifies against
the single implementation using `Puppet.log_exception`. Additionally
it now has unit tests.