So, shouldn't we use the logstash::defaults_location "just in case", or are
you trying to keep all of the sub-classes decoupled?

Thanks,

Trevor


On Wed, Sep 11, 2013 at 4:05 AM, Richard Pijnenburg <
notifications@github.com> wrote:

> In manifests/service.pp:
>
> > @@ -163,6 +163,15 @@
> >
> >      } else {
> >
> > +      file { "${logstash::defaults_location}/logstash":
>
> Hi,
>
> the params.pp file contains default values which in some cases can be
> overwritten in the init.pp file.
> Seeing as the location for the defaults files is never custom i've coded
> the location in the params.pp file based on the distribution / os is being
> used.
> that way its flexible to work for multiple distro's
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/logstash/puppet-logstash/pull/85/files#r6287963>
> .
>



-- 
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --