Maybe we should re-write everything in TypeScript ;)


On Fri, Jan 4, 2013 at 11:23 AM, Kevin Decker <notifications@github.com>wrote:

> In src/collection.js:
>
> > @@ -19,6 +19,9 @@ Thorax.Collection = Backbone.Collection.extend({
> >    isPopulated: function() {
> >      return this._fetched || this.length > 0 || (!this.length && !_.result(this, 'url'));
> >    },
> > +  shouldFetch: function(options) {
> > +    return options.fetch && !!_.result(this, 'url') && !this.isPopulated();
>
> Types are meaningless :) But then again we are spending a lot of time on
> two chars that are already commited and basically just a stylistic concern.
> Willing to drop it :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/walmartlabs/thorax/pull/90/files#r2553666>.
>
>