:-)

I suspect a combination of there being several types of user role object
(due to sqlalchemy or my limitations with sqlalchemy) and it bein simpler
to compare a tuple than a relatively opaque object

But certainly a refactor

Paul Brian
07540 456 115
paul@mikadosoftware.com
Guiding you towards Continuous Delivery of software and business value.

On 18 Mar 2013, at 18:43, Philip Schatz <notifications@github.com> wrote:

In rhaptos2/repo/cnxbase.py:

> +        else:
> +            for usrdict in acllist:
> +                # I am losing modified info...
> +                self.adduserrole(userrole_klass, usrdict)
> +
> +    def adduserrole(self, userrole_klass, usrdict):
> +        """ keeping a common funciton in one place
> +
> +        Given a usr_uuid and a role_type, update a UserRole object
> +
> +        I am checking setter_user is authorised in calling function.
> +        Ideally check here too.
> +        """
> +        t = self.get_utcnow()
> +
> +        # why not pass around USerROle objects??

Indeed, why not?

—
Reply to this email directly or view it on
GitHub<https://github.com/Connexions/rhaptos2.repo/pull/91/files#r3418071>
.

-- 


www.mikadosoftware.com

See your software improve with every change.