two methods plus tests
finish commit