heat tests : functional tests remove erroneous finally clause

Some tests have had a finally clause added which means they delete the
stack before doing any tests, even when it is created successfully.  Doh!

Change-Id: I7cefd313b9f810067304fe19f58a038226555b86
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat tests : CFN_API functional tests NoEcho Parameters fix

NoEcho is now implemented in the engine for parameters, so we
need to change the expected ParameterValues to '******' to match
the API response for the NoEcho==True parameters

Change-Id: I4f50633dc5358e8779bfbaf03dda2f7fe1b7d452
Signed-off-by: Steven Hardy <shardy@redhat.com>
Turn off tag_date on branch master

rpmbuild actually requires no date tag in the version.

Change-Id: I8bffff1924b4bc43324346f799d866fcc0f51a55
heat tests : functional tests align eip output with Folsom

Folsom novaclient floating_ips.list() returns the instance ID as
instance_id not resource_id

Change-Id: Ie958ada0984f9927cd490f01bd4db3102c53090a
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat engine : map DBInstance DBSecurityGroups parameter correctly

The DBInstance nested stack template defines a DBSecurityGroups list parameter,
which should be "CommaDelimitedList" type, curently it's a "List" type which
breaks when the template is parsed.  To make this work we also have to mangle
the property (passed in the top level template) format to match the parameter
format, because in AWS Lists are not represented in the same way for Properties and
Parameters (sigh..)

fixes bug 1096099

Change-Id: Ie078d61847d89ea9dcd55f798b808e595c2d2e12
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat tests : remove pointless get_ssh_client

get_ssh_client() doesn't actually do anything, so just reference the
attribute directly

Change-Id: I6a88b09953a7ca5a0e2675ac1c2c5a99b8cf724a
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat tests : remove unused get_sftp_client()

get_sftp_client is not needed so remove it

Change-Id: I9fb0670730e808c1f2786866ad3451f8e9f38789
Signed-off-by: Steven Hardy <shardy@redhat.com>
Add missing files to generated tarballs

Fix MANIFEST.in so that all files in the repository are included
in the generated tarballs. Fixes bug 1096068.

Change-Id: I7ec7e2fcf6951357b58469539a5d552b8df66408
Merge "heat tests : functional tests align eip output with Folsom"
Merge "heat tests : remove pointless get_ssh_client"
Merge "heat tests : remove unused get_sftp_client()"
Merge "heat engine : map DBInstance DBSecurityGroups parameter correctly"
Handle different cloud-init versions gracefully

Change loguserdata script to python to allow easy detection of which
version of cloud-init installed. Some logging was added to
part-handler.

Took out injecting the command to touch provision-finished in the user
data. This is now handled in loguserdata.py.

Note that up until cloud-init version 0.6.0, the user data is not
passed to part-handler. This behavior is why it's not possible to log
the provisioning process with older versions. (Technically could rely
on the redirection support added post 0.6.0, but having a separate
file just for provisioning seems beneficial.)

fixes bug 1072921

Change-Id: I9005a21bfb74f27208f9195a6e10e1d2b474e91f
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
heat engine : ensure create thread exits on stack delete

Detect GreenletExit exception when creating resources - this may
happen if the stack gets deleted while the stack is still in
CREATE_IN_PROGRESS state.  If we don't detect this then the stack
continues trying to create resources during/after the stack has been
deleted, with predictably nasty results..

fixes bug 1096150

Change-Id: Ieb6ed38d0000cd6fe3bc1af2eb5d2e5eecc74fb4
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat engine : allow NestedStack template validation to work

Nested stack templates (e.g WordPress_Composed_Instances.template)
will currently fail validation because FnGetAtt attempts to get
outputs for a stack which doesn't yet exist.  So add a fallback which
returns a string "None" for Outputs.* which will allow template
validation to succeed, and will still return the actual output when
the nested stack has actually been created.

fixes bug 1097290

Change-Id: Ic3f48cfc2f047c104946d6dde533143d0d91a32c
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat engine : DBInstance fix so nested stack is deleted

Currently the RDS DBInstance resource inherits from stack.Stack but it
should be stack.NestedStack, which implements handle_delete whereas
stack.Stack does not, meaning the DBInstance nested stack is never
deleted when the owning stack gets deleted.

fixes bug 1097299

Change-Id: I865611d4de9ea4c3caa43c7a11a28924602a5b0d
Signed-off-by: Steven Hardy <shardy@redhat.com>
Merge "heat engine : ensure create thread exits on stack delete"
Merge "heat engine : allow NestedStack template validation to work"
heat engine : LoadBalancer resource delete nested stack

Ensure LoadBalancer resource deletes the underlying nested
stack when the owning stack is deleted - needs to inherit
from stack.NestedStack as this implements handle_delete()

fixes bug 1097394

Change-Id: I2002bed361511a495cbdf38cad7b61e148a68ba2
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat engine : DBInstance don't pass credentials to cfn-init

Don't create user/accesskey and pass them to cfn-init as resource
metadata for internal nested stacks is not available via the cfn API
so passing them causes an error in the engine logs (and creates some
unnecessary keystone credentials)

fixes bug 1097362

Change-Id: If2fe484d834e3e5730b21a18c363a5bf5a4c45f6
Signed-off-by: Steven Hardy <shardy@redhat.com>