On 2013-08-07 17:39, David Mason wrote:
> In zanata-war/src/main/java/org/zanata/search/ClassIndexer.java:
> 
>>     {
>>        Long result = (Long) session.createCriteria(clazz).setProjection(Projections.rowCount()).list().get(0);
>>        return result.intValue();
>>     }
>>  
>> -   public void index(FullTextSession session, IndexerProcessHandle handle, Class<T> clazz)
>> +   public void index(Class<T> clazz)
> 
> Why does this take a class argument when it should already have a class
> instance variable? Seems strange to be using a ClassIndexer of one class
> to index a different class. It also seems like this argument is only
> used for generating log messages. Seems like this class needs some
> general attention to make sure it is sensible.
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/78/files#r5625290>.
> 

Only because I missed one.  I've been trying to remove some of the
obviously redundant objects, but I don't have time for a complete
refactor of the class right now.

-- 
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat