+1

Le 21/10/2013 00:30, Pieter Hintjens a écrit :
> It's often simpler to merge, and then fix things as you think they 
> should be, rather than critique the patch, in my experience. … <#>
> On Sun, Oct 20, 2013 at 11:47 PM, Richard Newton 
> <notifications@github.com>wrote: In src/proxy.cpp: > + msg_t ctrl; > + 
> rc = ctrl.init (); > + if (unlikely (rc < 0)) > + return -1; > + rc = 
> ctrl.copy (msg); > + if (unlikely (rc < 0)) > + return -1; > + rc = 
> capture_->send (&ctrl, 0); > + if (unlikely (rc < 0)) > + return -1; > 
> + } > + > + // process control command > + int size = msg.size(); > + 
> char* message = (char*) malloc(size + 1); > + memcpy(message, 
> msg.data(), size); Don't see the need for the extra malloc here, you 
> only use memcmp anyway so why not use msg.data() directly and skip the 
> malloc/free? — Reply to this email directly or view it on 
> GitHub<https://github.com/zeromq/libzmq/pull/712/files#r7083737> .
> -- - Pieter Hintjens CEO of iMatix.com Founder of ZeroMQ community 
> blog: http://hintjens.com
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/zeromq/libzmq/pull/712/files#r7083904>.
>