encoding/xml: reject > chain with non-element

Fixes issue 5033.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7764044
go/types: delete from main repo; part of move to go.exp
See also https://codereview.appspot.com/7656044

R=golang-dev, gri, rsc
CC=golang-dev
https://codereview.appspot.com/7625048
test/bench/garbage: fix parser benchmark

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7762046
spec: rewrite the description of panic and recover.
The old description was misleading and inaccurate.

Fixes issue 4774.

R=iant, rsc, gri
CC=golang-dev
https://codereview.appspot.com/7761044
misc/bbedit, misc/notepadplus: remove executable bits from files.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/7765043

Committer: Ian Lance Taylor <iant@golang.org>
html/template: Ensure release of namespace mutex in Template.Execute()

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/6727046

Committer: Rob Pike <r@golang.org>
api/next.txt: remove references to go/types, now in separate repo

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7663045
cmd/ld: fix 'use after free' error in new obj code

Many thanks to Elias Naur for finding this with Valgrind on Linux.
Perhaps this is what is breaking the windows/amd64 builder.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7595044
net: Plan 9: add lookupProtocol

Needed by TestResolveIPAddr. This makes us pass tests
again.

R=rsc, rminnich, ality, bradfitz
CC=golang-dev
https://codereview.appspot.com/7737043

Committer: Ron Minnich <rminnich@gmail.com>
runtime: Plan 9, 32-bit: fix build by updating call to open()

With the global redefinition of runtime·open by CL 7543043,
we need to provide a third argument and remove the cast
to the string.

Fixes build on 386 version of Plan 9.

R=khr, rsc, rminnich, ality
CC=golang-dev
https://codereview.appspot.com/7644047

Committer: Ron Minnich <rminnich@gmail.com>
net: make sure to use /tmp in unix domain socket tests

R=golang-dev, bradfitz, dave, rsc
CC=golang-dev
https://codereview.appspot.com/7547044
image/jpeg: ignore extraneous data, the same as what libjpeg does.

Fixes issue 4705.

Note that libjpeg will print a warning to stderr if there are many
extraneous bytes, but can be silent if the extraneous bytes can fit
into its int32 bit-buffer for Huffman decoding. I'm guessing that
this is why whatever encoder that produced the image filed for issue
4705 did not realize that they are, strictly speaking, generating an
invalid JPEG. That issue's attached image has two extraneous bytes.

For example, piping the program below into libjpeg's djpeg program
will print an "18 extraneous bytes" warning, even though N == 20.

$ cat main.go
package main

import (
        "bytes"
        "image"
        "image/color"
        "image/jpeg"
        "os"
)

const N = 20

func main() {
        // Encode a 1x1 red image.
        m := image.NewRGBA(image.Rect(0, 0, 1, 1))
        m.Set(0, 0, color.RGBA{255, 0, 0, 255})
        buf := new(bytes.Buffer)
        jpeg.Encode(buf, m, nil)
        b := buf.Bytes()
        // Strip the final "\xff\xd9" EOI marker.
        b = b[:len(b)-2]
        // Append N dummy 0x80 bytes to the SOS data.
        for i := 0; i < N; i++ {
                b = append(b, 0x80)
        }
        // Put back the "\xff\xd9" EOI marker.
        b = append(b, 0xff, 0xd9)
        os.Stdout.Write(b)
}
$ go run main.go | djpeg /dev/stdin > /tmp/foo.pnm
Corrupt JPEG data: 18 extraneous bytes before marker 0xd9

The resultant /tmp/foo.pnm is a perfectly good 1x1 red image.

R=r
CC=golang-dev
https://codereview.appspot.com/7750043
test/bench/go1: add http test

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7529048
go/test/bench/go1: add regexp test

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7480047
net: require of both -external and -ipv6 flags to run IPv6 multicast tests

On BSD variants, the tests need surely constructed IPv6
routing table.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7776043
doc: clarify that gccgo is a GCC front-end

R=golang-dev, r, iant, iant
CC=golang-dev
https://codereview.appspot.com/6454072

Committer: Ian Lance Taylor <iant@golang.org>
misc/emacs: Fix indentation for code following multiline function declarations

Correctly indent the body of functions that have been declared
over multiple lines. See http://play.golang.org/p/MHMwNDbFyf for
an example.

Previously, the body of the function would be indented as deep as
the continuation line of the function declaration. Now it gets
indented as deep as the func keyword.

R=adonovan, cw, patrick.allen.higgins
CC=golang-dev
https://codereview.appspot.com/7628043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
net: fix windows and plan9 build

Don't call unix-only function in test init.

R=golang-dev, alex.brainman
CC=golang-dev
https://codereview.appspot.com/7778043
unicode/utf8: fix insignificant typos in tests

Fixes issue 4972.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7649044

Committer: Brad Fitzpatrick <bradfitz@golang.org>
misc/pprof: fix address lookup regression on Linux

Just use "go tool addr2line" no matter what, since we know
it works for all OSs.

Fixes issue 4818.

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/7526047

Committer: Rob Pike <r@golang.org>