better use onChange instead of keyup