Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
https://bugs.webkit.org/show_bug.cgi?id=106514

This is old code, as these can no longer get out of sync.
permmaLinkURLHash is generated from currentState, which is set only
from the location.  The commment about how these can get out of sync
refers to a function that no longer exists.

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/dashboard_base.js:
(handleLocationChange):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Node::containingShadowRoot should be constant time
https://bugs.webkit.org/show_bug.cgi?id=106494

Patch by Elliott Sprehn <esprehn@gmail.com> on 2013-01-09
Reviewed by Dimitri Glazkov.

There's no reason to traverse up the tree to find the containing
ShadowRoot when we already know if we're in a ShadowRoot by looking at
the treeScope().

No new tests, just refactoring.

* dom/Node.cpp:
(WebCore::Node::containingShadowRoot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[QT][EFL][WK2] Rename scale members in PageViewportController.
https://bugs.webkit.org/show_bug.cgi?id=106499

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

Rename from m_contentsScale to m_pageScaleFactor and from devicePixelRatio() to
deviceScaleFactor() to match terms of WebCore.

* UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::devicePixelRatio):
* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::deviceScaleFactor):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):
* UIProcess/PageViewportController.h:
(PageViewportController):
(WebKit::PageViewportController::currentContentsScale):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove deviceScaleFactor argument in computeMinimumScaleFactorForContentContained().
https://bugs.webkit.org/show_bug.cgi?id=106500

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

deviceScaleFactor argument is not used after r139189.

Source/WebCore:

No new tests. Refactoring only.

* dom/ViewportArguments.cpp:
(WebCore::computeMinimumScaleFactorForContentContained):
* dom/ViewportArguments.h:
(WebCore):

Source/WebKit2:

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::updateMinimumScaleToFit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] [WebGL] Remove GLX dependencies from X11WindowResources..
https://bugs.webkit.org/show_bug.cgi?id=106319

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

This patch removes GLX specific calls from X11WindowResources.
This class is shared by both GLX and EGL implementations.

* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::setGeometry):
* platform/graphics/surfaces/glx/X11WindowResources.cpp:
(WebCore::X11OffScreenWindow::reSizeWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=106520

Reviewed by James Robinson.

Part of a larger refactoring series. See tracking bug 82948.

* DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[JSC] REGRESSION(r135093): A form control with name=length overrides length property on form.elements
https://bugs.webkit.org/show_bug.cgi?id=105775

Reviewed by Sam Weinig.

Source/WebCore: 

Fixed the bug by respecting properties on ancestor classes.

Test: fast/dom/collection-length-should-not-be-overridden.html

* bindings/js/JSDOMBinding.h:
(WebCore::getStaticValueSlotEntryWithoutCaching): Added.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody): Use getStaticValueSlotEntryWithoutCaching to climb up the class
hierarchy.

LayoutTests: 

Added a regression tests for all known HTMLCollection sublcasses except HTMLNameCollection,
which is used only to implement named getters on window and document objects and HTMLPropertiesCollection
since it's not enabled on all ports yet.

* fast/dom/collection-length-should-not-be-overridden-expected.txt: Added.
* fast/dom/collection-length-should-not-be-overridden.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Updated parameters in GCE build scripts so they now work.
https://bugs.webkit.org/show_bug.cgi?id=106523

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-09
Reviewed by Adam Barth.

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/cold-boot.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline the binding test after r139278.

* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Add win mac expectations for r139256
https://bugs.webkit.org/show_bug.cgi?id=106404

Unreviewed gardening.

* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: Added.
* platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make caret repainting container-aware
https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

* editing/FrameSelection.cpp:
(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* editing/FrameSelection.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintSelection):
* rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

* fast/repaint/caret-with-transformation.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: [Network] Data grid header and content cells are misaligned.
https://bugs.webkit.org/show_bug.cgi?id=105795

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Header and content tables have different width -> same percent values
turn to different cell widths.

* inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
* inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.
(.data-grid .data-container): Remove artificial padding.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

* fast/forms/button-inner-block-reuse-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/button-inner-block-reuse-expected.txt.
* platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Added.
* platform/mac/fast/forms/button-inner-block-reuse-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Don't throw exceptions when we don't have a callstack
https://bugs.webkit.org/show_bug.cgi?id=104849

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Check array details.callFrames.length before accessing array;

No new tests, but this fix may help us find the cause of 'other' reasons.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update expectations for fast/forms/button-generated-content.html

Unreviewed gardening.

* fast/forms/button-generated-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/button-generated-content-expected.txt.
* platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Added.
* platform/mac/fast/forms/button-generated-content-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2][EFL] Add guard around NativeWebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=105846

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-01-09
Reviewed by Benjamin Poulain.

Fix EFL build without TOUCH_EVENTS.

* Shared/efl/NativeWebTouchEventEfl.cpp: Add TOUCH_EVENTS guard.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
New chromium-mac pixel baseline for gradient-background-leakage-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed gardening.

* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
IndexedDB: Allow createIndex/createObjectStore to be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=106377

Reviewed by Tony Chang.

Source/WebCore:

Migrate implementations of createIndex/deleteIndex,
createObjectStore/deleteObjectStore over to IDBDatabaseBackendImpl,
so that they can be asynchronous in multi-process ports.

Has the side effect of removing the last consumers of
IDBIndexBackendImpl and IDBObjectStoreBackendImpl. The former
is removed complete and the latter becomes a temporary namespace
pending a further more mechanical code shuffle.

A key refactoring effect is that the IDBDatabaseBackendImpl
now contains the authoritative IDBDatabaseMetadata hierarchy,
and updates to it are consolidated in one place rather than
scattered across a parallel object tree.

No new tests as this is just refactoring.

* Modules/indexeddb/IDBBackingStore.cpp: Simplify objectstore/index loading and propagate errors.
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::getIndexes):
* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Dependency cleanup.
* Modules/indexeddb/IDBCursorBackendImpl.h: Dependency cleanup.
(WebCore):
* Modules/indexeddb/IDBDatabase.cpp: Frontend IDBObjectStores no longer hold onto backend objects.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Add all create/deleteIndex operations from IDBIndexBackendImpl.
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(DeleteObjectStoreOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(DeleteObjectStoreAbortOperation):
(CreateIndexOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore):
(DeleteIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(CreateIndexAbortOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(DeleteIndexAbortOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::GetOperation):
(WebCore::IDBDatabaseBackendImpl::addObjectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::addIndex):
(WebCore::IDBDatabaseBackendImpl::removeIndex):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::DeleteRangeOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Load directly into metadata from backing store.
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
* Modules/indexeddb/IDBIndexBackendImpl.cpp: Removed.
* Modules/indexeddb/IDBIndexBackendImpl.h: Removed.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore): Frontend IDBIndex objects no longer hold onto backend.
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::create):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
* Modules/indexeddb/IDBTransaction.h:
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::objectStore):
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove this test as it makes no sense once the objectstore/index
hierarchy is gone.

* tests/IDBDatabaseBackendTest.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix after r139266.

r139266 broke the debug build of the gstreamer backend due
to a missing header include.

No new tests, no behavior change.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Add gstreamer 1.0.5 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=106178

Reviewed by Laszlo Gombos.

.:

Update EFL CMake configuration to require gstreamer
1.0.5.

* Source/cmake/FindGStreamer.cmake:
* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

No new tests, no behavior change for layout tests.

* PlatformEfl.cmake:

Source/WebKit:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

* PlatformEfl.cmake:

Source/WebKit/efl:

Fix compilation error when using gstreamer 1.0.

* WebCoreSupport/FullscreenVideoControllerEfl.cpp:
* WebCoreSupport/FullscreenVideoControllerEfl.h:

Tools:

Add gstreamer 1.0.5 to EFL's jhbuild configuration.

* efl/jhbuild.modules:

LayoutTests:

Skip several media tests that are crashing with gstreamer 1.0.

* platform/efl/TestExpectations:
* platform/efl/media/sources-fallback-codecs-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139291 268f45cc-cd09-0410-ab3c-d52691b4dbfc