lot of tests for failure case but none for success