Prevent nova services' coverage data from combining into nova-api's

Now if combining a coverage report once, nova services' coverage
data are combined into nova-api's.
This renames nova-api coverage datafile to .nova-coverage.api and
creates a new coverage instance to combine when reporting.

Fixes bug: 1152475

Change-Id: I90b6535d490cf0123a127f8752986edd782ef37e
List InstanceNotFound as a client exception

get_instance_nw_info() in nova.network.manager should list
InstanceNotFound as a client exception for rpc. This to prevent the
rpc layer from logging a traceback when this exception is raised.
This is an expected type of exception that should be left to the
client to handle.

Resolves bug 1157411.

Change-Id: I6735fb8a386f2256ac8af0ce7fdb36ef7a00b6ce
Fix Hyper V instance conflicts

Fixes bug 1152368

If the hyperv driver attempts to boot an instance and a previous
instance with the same name was not properly removed, the boot will
fail due to an error creating root.vhd.  This only happens when
using CoW images.  This fix deletes the instance directory before
creating the new instance so that there will never be an old image
to interfere with creation of the new one.

This is most likely to be an issue in development and test
environments that toggle between versions of nova with no migration
path.

Change-Id: I21eab01590c426234b4b9a55abec4b2d2df0e168
xenapi: rpmbuild fixes

Fixes bug 1157695

This fix removes the parted dependency from the rpm specification file,
and also gets rid of the assumption, that the build-rpm.sh is executed
at a specific directory.

Change-Id: I1dcf9096a783a88bc09af0f4f4d5541a7e505748
Remove unnecessary DB call to find EC2 AZs.

Update get_availability_zone_by_host, so it doesn't need a list of services,
and remove unneeded service_get_all_by_host calls. This removes N DB calls in
the EC2 api when doing a DescribeInstances, where N is number if instances
that are being described.

Partially fix bug 1157437

Change-Id: I0050ba736828faad94549bc6e55f4ca1d05dcbe7
Remove unnecessary checks in api.py

Remove existing check to ensure instance was running
when adding or removing security groups to/from an
instance.
Modified unit test accordingly
Fixes bug 1107721

Change-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b
Adds return-type in two functions' docstrings

Change-Id: Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c
Fixes: bug #1130922
Fixes argument order of quantumv2.api.get_instance_nw_info

Fixes bug #1159042

Change-Id: I04136707cdf2ca716dabd92aa7a471c291a3b4eb
Make iptables drop action configurable.

Resolves bug 1013893 by allowing the setting of the iptables drop
action with a configuration flag. It is expected that this would be
used for run a LOGDROP action before actually dropping the packet.

DocImpact: the drop action for iptables rules can now be configured
for nova-network users with the iptables_drop_action flag.

Change-Id: I15720d2742955611929a4d7181a269795296e025
Reformat openstack-common.conf

Use the new 'module' option in openstack-common.conf which is a
multi-string option, allowing each module name to be placed on a
separate line.

This makes it much easier to review changes to the modules list.

Change-Id: I218601a3720287071f05b9f2f624c1de4442d34f
Include Co-authored-by entries in AUTHORS

Import latest openstack.common.setup from oslo-incubator, which includes
the fix to include Co-authored-by entries in AUTHORS.

Fixes bug 1158319

Change-Id: I4f0ba09816730d10869c4ca639e2930d266eac8f
Add missing info to docstring.

The example return value in this docstring did not reflect that the zone
for each service is included as well.  Add 'zone', and also add a
compute of compute entries to the list.

Fix bug 1159897.

Change-Id: I8979a4a307d0ad77e8eff4fa71e0be3062a526e2
Merge "Remove unnecessary checks in api.py"
Merge "Reformat openstack-common.conf"
Merge "Add missing info to docstring."
NoneType exception thrown if driver live-migration check returns None

XenAPI driver live-migration checks must return dicts as required by
the virt api interface.

Resolves bug 1158603.

Change-Id: I0db364a17e3069b0b7e3f19030afc35283edecfb
Fix /servers/<instance-id>os-security-groups using quantum

When using quantum security groups:
	GET /servers/<instance-id>/os-security-groups
aways returns an empty list. This patch adds a call to
get_instance_security_groups in the api implemenation of security groups.
This method passes both the instance_id and instance_uuid so the api layer
does not need to be aware of which underlying implementation is being used.
The instance_id is needed when using nova and when using quantum the
instance_uuid is needed so both need to be passed.

Fixes bug 1159793

Change-Id: I372adcf93c55d4e6469ef08429ec260d3387f9fe
set up FakeLogger for root logger.

A recent change in openstack.common.log was made such that it
initialized the root logger instead of the project specific logger,
'nova' in this case.  Update the unit tests for this to fix the problem
where unit tests spam the console with log output.

Fix bug 1159978.

Change-Id: Id64a5b078b4024c3269086ed5d64940b3a38ddfa
Merge "Include Co-authored-by entries in AUTHORS"
Merge "Remove unnecessary DB call to find EC2 AZs."