A comment to that effect in the code would make it more readable for others
in the future, who might want to go the rest of the way with the
implementation and testing.

On Thu, Feb 7, 2013 at 7:47 PM, Eric Hunsberger <notifications@github.com>wrote:

> In theano/tensor/blas_c.py:
>
> > @@ -497,22 +497,44 @@ def gemv_c_code(aa, xx, yy, zz, alpha, beta, destructive, fail):
> >                      float alpha = ((dtype_%(alpha)s*)PyArray_DATA(%(alpha)s))[0];
> >                      //fprintf(stderr, "alpha=%%f\\n", alpha);
> >                      //fprintf(stderr, "sx  sy %%i %%i\\n", Sx, Sy);
> > -                    sgemv_(&TRANS, &Nx1, &Nx0,
> > -                        &alpha,
> > -                        (float*)(PyArray_DATA(%(xx)s)), &Sx0,
> > -                        (float*)yy_data, &Sy,
> > -                        &fbeta,
> > -                        (float*)zz_data, &Sz);
> > +
> > +                    if (Nx0 == 1 && Sx1 == 1)
>
> It probably doesn't. I didn't have a test case where Sx1 != 1, so I wasn't
> sure that my new code would work for that case, and figured it was better
> to fall back to the slower, reliable code than risk breaking something.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Theano/Theano/pull/1202/files#r2936784>.
>
>