core: Remove domains member from storage_pool

Removed the private member "domains" from the storage_pool class. This
member was never updated (in fact, there are no methods to modify it!),
and never queried (no such methods exists either), and was only used in
the equals(Object) and hashCode() methods. Since its value is always
null, it's useless to continue holding it.

Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove userGroup member from tags

Removed the private member "userGroup" from the tags class. This
member was never updated (in fact, there are no methods to modify it!),
and never queried.

Its only use was in its getter, which was never used anywhere in the
code. Thus, it's useless to continue holding it.

Change-Id: I9e965c455a426afbd894caa85059d3d39159b84e
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: VmPayload: efficient map iteration

Replaced a keySet() iteration with a more efficient entrySet()
iteration in the VmPayload class.

Change-Id: Idb7d010c8744a161bf49d03fe9fc1b6c1c0fc32f
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: HOST_DEFAULT_SPM_PRIORITY constant as static

Changed the HOST_DEFAULT_SPM_PRIORITY constant in VdsStatic to be
static, as per java's conventions for constants.

Change-Id: I504c3550713e78915fb2230fdbdb3ae402a19c7d
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: DEFAULT_PRESTARTED_VMS constant as static

Changed the DEFAULT_PRESTARTED_VMS constant in vm_pools to be
static, as per java's conventions for constants.

Change-Id: I47cf4450bdedfebc49fc5ec49af80d586e972a52
Signed-off-by: Allon Mureinik <amureini@redhat.com>