Oh right - so we don't add these validations because when Users are
created, their data are subsequently fetched from the API here
https://github.com/yammer/sched.do/blob/master/app/controllers/sessions_controller.rb#L7

So we can either leave the validations off or create a new User (without
saving), do the fetch, then save.

On Tue, Jan 29, 2013 at 11:56 AM, malandrina <notifications@github.com>wrote:

> In spec/models/user_spec.rb:
>
> > @@ -178,6 +178,7 @@
> >      user.nickname.should == oauth_hash['name']
> >      user.yammer_profile_url.should == oauth_hash['web_url']
> >      user.yammer_network_id.should == oauth_hash['network_id']
> > +    user.yammer_network_name.should == oauth_hash['network_name']
> >      user.extra.should == oauth_hash.to_yaml
> >    end
> >  end
>
> I initially decided not to add a validation for yammer_network_namebecause it's similar to
> yammer_network_id, and there isn't a validation for yammer_network_id.
>
> I think an argument can be made for adding validations for both of these
> attributes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/yammer/sched.do/pull/288/files#r2814746>.
>
>



-- 
@adarshp <http://twitter.com/adarshp>
developer for thoughtbot, inc <http://www.thoughtbot.com>
313.454.1515 (m)

Scheduling with me? See bit.ly/adarshcalendar