add compute p sign