Is this the right way this should be done?