default type change to string
ambiguous param name
add logging