C: add Cosmos Nicolaou (Google CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7314103
go/parser: cleanups following CL 7307085

- use the new AllErrors flag where appropriate
- unless AllErrors is set, eliminate spurious
  errors before they are added to the errors list
  (it turns out that reporting spurious errors always
  leads to too many uninformative errors after all)

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7323065
src/cmd/gc: fix some typos in the escape analysis comments

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7342044
misc/dashboard/builder: record build result on dashboard

This is part one of two changes intended to make it easier to debug builder failures.

runOutput allows us to control the io.Writer passed to a subcommand. The intention is to add additional debugging information before and after the build which will then be capture and sent to the dashboard.

In this proposal, the only additional information is the build status. See http://build.golang.org/log/e7b5bf435b4de1913fc61781b3295fb3f03aeb6e

R=adg
CC=golang-dev
https://codereview.appspot.com/7303090
log/syslog: fix channel race in test.

R=golang-dev, minux.ma, iant, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/7314057

Committer: Dave Cheney <dave@cheney.net>
cmd/ld: fix -s flag for ELF executables

This fixes a regression introduced in changeset 98034d036d03
which added support for producing host object files.

R=rsc, minux.ma
CC=dave, golang-dev
https://codereview.appspot.com/7307107
doc/contribute: fix some tags, remove extra space.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7327048

Committer: Andrew Gerrand <adg@golang.org>
go/doc: add support for arbitrary notes

Add support for arbitrary notes of the form // MARKER(userid): comment
in the same vein as BUG(userid): A marker must be two or more upper case [A-Z] letters.

R=gri, rsc, bradfitz, jscrockett01
CC=golang-dev
https://codereview.appspot.com/7322061

Committer: Robert Griesemer <gri@golang.org>
cmd/godoc: add support for doc.Package.Notes

Add support for displaying the notes of the form 'MARKER(userid): comment' now collected by the go/doc package. Any two or more uppercase letters are recognised as a marker.

R=gri, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/7334044

Committer: Robert Griesemer <gri@golang.org>
runtime: expand error for signal received on non-Go thread.

We call runtime.findnull dynamically to avoid exceeding the
static nosplit stack limit check.  (Thanks minux!)

Fixes issue 4048.

R=rsc, minux.ma, ality
CC=golang-dev
https://codereview.appspot.com/7232066

Committer: Russ Cox <rsc@golang.org>
net: delete TestDialTimeoutHandleLeak

It is too flaky. Tried to make it more reliable,
but that affects other tests (they run too long),
because we do unusual things here, like attempting
to connect to non-existing address and interrupt.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7314097
mime: use .wav instead of .bmp during windows tests

Some systems do not have .bmp mime.

Update issue 4723.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/7326047
mime: do not test for .wav on windows

Even builders don't have that mime type

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/7314106
runtime: fix debug output

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7312101
crypto/x509: support IP SANs.

Subject Alternative Names in X.509 certificates may include IP
addresses. This change adds support for marshaling, unmarshaling and
verifying this form of SAN.

It also causes IP addresses to only be checked against IP SANs,
rather than against hostnames as was previously the case. This
reflects RFC 6125.

Fixes issue 4658.

R=golang-dev, mikioh.mikioh, bradfitz
CC=golang-dev
https://codereview.appspot.com/7336046
runtime: fix running under nohup

There are two ways nohup(1) might be implemented:
it might mask away the signal, or it might set the handler
to SIG_IGN, both of which are inherited across fork+exec.
So two fixes:

* Make sure to preserve the inherited signal mask at
minit instead of clearing it.

* If the SIGHUP handler is SIG_IGN, leave it that way.

Fixes issue 4491.

R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://codereview.appspot.com/7308102
exp/cookiejar: fix windows builder

TBR=nigeltao
CC=golang-dev
https://codereview.appspot.com/7322084
runtime: fix build on linux

In addition to the compile failure fixed in signal*.c,
preserving the signal mask led to very strange crashes.
Testing shows that looking for SIG_IGN is all that
matters to get along with nohup, so reintroduce
sigset_zero instead of trying to preserve the signal mask.

TBR=iant
CC=golang-dev
https://codereview.appspot.com/7323067
exp/cookiejar: fix windows/386 build

More mysteriously broken tests.

TBR=nigeltao
CC=golang-dev
https://codereview.appspot.com/7342048
encoding/binary: make type error more specific

Right now it says 'invalid type S' for a struct type S.
Instead, say which type inside the struct is the problem.

Fixes issue 4825.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7301102