finish modify, need refactor
bug in shared preference