We chatted about this offline. There's a subtle difference between fluent mutators with set prefixes and methods that are optionally fluent, or optionally have a return value (e.g. jQuery.text()). This was an architectural decision for consistency over uncertainty.

On Jul 25, 2013, at 11:46 AM, Owen Davis <notifications@github.com> wrote:

> In includes/wikia/services/SolrDocumentService.class.php:
> 
> > +			$queryService = $this->getFactory()->getFromConfig( $config );
> > +			$resultSet = $queryService->search();
> > +			$result = isset( $resultSet[$docId] ) ? $resultSet[$docId] : null;
> > +			if ( $result !== null ) {
> > +				self::$documentCache[$docId] = $result;
> > +			}
> > +		}
> > +		return $result;
> > +	}
> > +	
> > +	/**
> > +	 * Allows us to set the current article ID for the document we want.
> > +	 * @param int $id
> > +	 * @return SolrDocumentService
> > +	 */
> > +	public function setArticleId( $id ) {
> consider not using "set" prefixes for fluent API methods?
> 
> —
> Reply to this email directly or view it on GitHub.
>