No, this test tests the methods in a test utility, not the query
builder (although yes, it does test it by proxy, but only incidentally -
if it were possible I would add a dependency on the QueryBuilder test,
but I don't think thats possible). 

The actual QueryBuilder test doesn't use this class, but if it did I
would still want this test to ensure that the methods are tested as
first-class citizens :)


On Fri, Sep 20, 2013 at 01:41:47AM -0700, David Buchmann wrote:
>    In tests/Doctrine/Tests/ODM/PHPCR/Tools/Test/QueryBuilderTesterTest.php:
> 
>  > @@ -0,0 +1,57 @@
>  > +<?php
>  > +
>  > +namespace Doctrine\Tests\ODM\PHPCR\Tools\Test;
>  > +
>  > +use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
>  > +use Doctrine\ODM\PHPCR\Tools\Test\QueryBuilderTester;
>  > +
>  > +class QueryBuilderTesterTest extends \PHPUnit_Framework_TestCase
> 
>    does that make sense? i mean, should we not just have the test for the
>    actual querybuiilder that is using this test helper? it feels like testing
>    a test to me :-) but i am ok if you want to merge this. do we have any
>    test that is actually using the helper yet?
> 
>    —
>    Reply to this email directly or [1]view it on GitHub.
> 
> References
> 
>    Visible links
>    1. https://github.com/doctrine/phpcr-odm/pull/332/files#r6481927