Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when failing to construct_limited_ids_condition.
Add coverage for the fact that pluck without an argument returns all the table's columns.
No point in memoizing a simple literal string.
Make NullRelation a bit more like a real relation by returning 0 for #calculate(:count)
Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.

This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control.
Add note about upgrading custom routes from `put` to `patch`.
use grep over select for consistency and efficiency
pass block directly to grep
Prevent side effects in `Hash#with_indifferent_access`.
Merge pull request #10767 from jmondo/master

Use grep instead of select with === in QueryMethods
Adding a test to make sure that using rake routes with the CONTROLLER
environment works correctly.
`RoutesInspector` deals with routes using regexp as `:controller` option
Merge pull request #10785 from senny/10782_routes_inspector_deals_with_controller_regexp

`RoutesInspector` deals with routes using regexp as `:controller` option
Fix regression in has_secure_password.

If the confirmation was blank, but the password wasn't, it would still save.
Extract ActionDispatch::Request#deep_munge

ActionDispatch::Request#deep_munge was introduced as a private method,
but was turned into a public one for the use of
ActionDispatch::ParamsParser.

I have extracted it into ActionDispatch::Request::Utils, so it does not
get mixed up with the Request public methods.
Merge pull request #10694 from steveklabnik/hsp_regression

Fix regression in has_secure_password.
Merge pull request #10803 from gsamokovarov/extract-deep-munge

Extract ActionDispatch::Request#deep_munge
Fix word order in documentation for with_lock
Merge pull request #10805 from pilaf/master

Fix word order in documentation for with_lock [ci skip]
Merge pull request #10783 from wangjohn/rake_routes_additional_environment

Adding the ability to filter routes by the verb
Add propery docs to ActionDispatch::Response [ci skip]

After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
a bit sparse. This class is useful when you're writing tests, as often you want to assert various
things about the response that's coming back. Better docs would make this easier for people new
to testing in Rails.

I only added some descriptions for various properties that were defined, and mostly just a sentence
or two. Most of these things are familliar if you're working with HTTP, but some words is better
than no words at all.

Hopefully further commits will fix up things that aren't just documentation.