Merge pull request #10055 from vipulnsward/remove_each_with_index_in_test

each_with_index  => each as we dont use index
Merge pull request #10054 from rubys/use_find_by_in_rdoc

Prefer find_by over dynamic finders in rdoc
Remove rails.png.

No reason to have a file, we've got data-URIs now! It didn't make sense
to me that you no longer have to remove public/index.html, but you still
need to remove rails.png. This means that you won't have to any more
when making a new Rails app.
Escape multibyte line terminators in JSON encoding

Currently, json/encoding respects the JSON spec (as it should) which 
disallows \n and \r inside strings, escaping them as expected.

Unfortunately, ECMA-262 (Javascript) disallows not only \n and \r in 
strings, but "Line Terminators" which includes U+2028 and U+2029. 
See here: http://bclary.com/2004/11/07/#a-7.3

This pull request adds U+2028 and U+2029 to be escaped.

# Why? 

It's very common to see something like this in a Rails template:

<script type="text/javascript"> 
var posts = <%= @posts.to_json %>;
</script>

If U+2028 or U+2029 are part of any attributes output in the to_json
call, you will end up with an exception.
In Chrome: Uncaught SyntaxError: Unexpected token ILLEGAL 

# Why not?

This is JSON encoding, and the JSON spec is specific about how to 
encode strings. U+2028 and U+2029 don't get special treatment.

Just trying to start a discussion... what do you do in your apps
to deal with this? Is there a convention I'm missing?
adding .gigkeep to default app/assets/images
Merge pull request #10056 from steveklabnik/remove_rails_png

Remove rails.png.
Fix tests from rails.png removal.

I'm giving @jlsuttles credit on this commit because she gave me the idea
and the actual converted image in 952289aabfb.
Refactor CollectionProxy#scope to avoid calling #extend.
Fix permanent cookie jar accessor typo
Be consistent when talking about cookies, key -> name
:scissors: spacing after private
Merge pull request #10059 from trevorturk/perm-cookie-jar-fix

Fix permanent cookie jar accessor typo
Rename DummyKeyGenerator -> LegacyKeyGenerator
Merge pull request #10060 from trevorturk/cookies-refactoring

Cookies refactoring
Merge pull request #10061 from trevorturk/dummy-key-generator-rename

Rename DummyKeyGenerator -> LegacyKeyGenerator
mark relation mutator as :nodoc: [ci skip]
.gitkeep -> .keep

Mentioned in a comment in e90c2d029edc by @frodsan.
We don't need to remove index.html any more.

Since it's not a real file any longer, no need to worry about
removing it when we reset the dummy.
CHANGELOG entry for rails.png removal.
Getting rid of a few other vestiges of rails.png.

We don't actually need a rails.png in the AP fixtures, the tests
that use it don't actually try to load the file.

We also don't need to get rid of it with the dummy reset either.

Finally, it's not needed in the sample application that's included
with the Rails Guides.