Add some long-overdue javadocs to the Updater

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Remove some obsolete TODOs in the Updater

Some of them are squashed already, for the rest we have Trac.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Squash some compiler warnings in the Updater

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Fix all resource leaks pointed out by Eclipse

Eclipse Juno has the very helpful feature in
Preferences>Java>Compiler>Errors/Warnings to warn about resource leaks.

URLClassLoader#close() is not available prior to Java 7, so this "fix"
was left out.

This happens to fix ticket #1635 partially.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Close a few more resources in the Updater

Missed by Eclipse...

This happens to fix the rest of the problems in ticket #1635.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Do not fail quietly when a lock file could not be renamed

The idea is to rename the lock file to the correct file name atomically.
Unfortunately, this is not possible on Windows because of its creative
permission model. However, we can at least complain loudly and fail
spectacularly when Windows tries to bite us again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Fix UpdaterTestUtils#addUpdateSite

It did not actually initialize the update site... :-(

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Be more verbose in UpdaterTestUtils#addUpdateSite

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Use the UpdaterTestUtils#addUpdateSite method in a real test

... now that we can dare to do so, as it works correctly.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Use forward slashes in the updater tests

Windows is quite capable of using forward slashes instead of backward
ones, thankyouverymuch. It would save so much developer time on this
globe if it would report forward slashes, too. Oh well. MS time tax.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
scripting-java test: give the garbage collector a chance

When loading classes via URLClassLoader, prior to Java 7 there is no
way to close the loader. Therefore we need to hope that garbage
collecting will convince the URLClassLoader to give up its stronghold
over the .jar file we so dearly want to delete after a successful
test.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Some defensive programming when testing scripting-java

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Add javadocs to the scripting-java test

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Only test scripting-java when javac is in the classpath

Otherwise it must fail...

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>