Build fix

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Added pasteboard after r152185.
* platform/efl/editing/deleting/delete-br-002-expected.txt: Updated after r152478.
* platform/efl/editing/execCommand/outdent-blockquote-test1-expected.txt:
Removed platform specific expectations after r152494.
* platform/efl/editing/execCommand/outdent-blockquote-test2-expected.txt: Ditto.
* platform/efl/editing/execCommand/outdent-blockquote-test3-expected.txt: Ditto.
* platform/efl/editing/execCommand/outdent-blockquote-test4-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove CodeBlock's notion of adding identifiers entirely
https://bugs.webkit.org/show_bug.cgi?id=119708

Reviewed by Geoffrey Garen.

Remove addAdditionalIdentifier entirely, including the bogus assertion.
Move the addition of identifiers to DFGPlan::reallyAdd

* bytecode/CodeBlock.h:
* dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::reallyAdd):
* dfg/DFGDesiredIdentifiers.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::finalize):
* dfg/DFGPlan.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CMake] Use the correct list of files when compiling ANGLESupport on Windows
https://bugs.webkit.org/show_bug.cgi?id=119439

Reviewed by Gyuyoung Kim.

* CMakeLists.txt: Use ossource_win.cpp instead of ossource_posix.cpp on Windows platforms.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixed an off-by-(sizeof(char*) - 1) bug.

Reviewed by Sam Weinig.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler): Allocate a sufficiently large buffer.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Encapsulate access to documentNamedItemMap and windowNamedItemMap
https://bugs.webkit.org/show_bug.cgi?id=119701

Reviewed by Darin Adler.

Encapsulate m_documentNamedItem and m_windowNamedItem by adding various methods on HTMLDocument.
This will help us doing more refactorings in the future.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
* dom/Element.cpp:
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem): Added.
(WebCore::HTMLDocument::removeDocumentNamedItem): Added.
(WebCore::HTMLDocument::addWindowNamedItem): Added.
(WebCore::HTMLDocument::removeWindowNamedItem): Added.
* html/HTMLDocument.h:
(WebCore::HTMLDocument::documentNamedItem): Added.
(WebCore::HTMLDocument::hasDocumentNamedItem): Added.
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements): Added.
(WebCore::HTMLDocument::windowNamedItem): Added.
(WebCore::HTMLDocument::hasWindowNamedItem): Added.
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements): Added.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening.

Add a missing result after r152911.

* platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix variable name |end| -> |size| in EventTarget::fireEventListeners
https://bugs.webkit.org/show_bug.cgi?id=119715

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01
and also fix variable names in FiringEventIterator.

* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
* dom/EventTarget.h:
(WebCore::FiringEventIterator::FiringEventIterator):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=85522

Reviewed by Andy Estes.

Source/WebCore:

Drive-by FIXMEs and trivial fixes for WebCore issues I noticed while working
on this bug. No behavior change expected.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::findFrameForNavigation):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):

Tools:

* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
when already done with a test. We already had this check in all UI delegate functions,
except for -webView:addMessageToConsole:withSource: somehow.

LayoutTests:

* http/tests/security/sandboxed-iframe-form-top-expected.txt: Console logging got
improved while this test was marked as skipped or flaky, updating the results.

* platform/mac/TestExpectations: Removed sandboxed-iframe-form-top.html, this test
no longer leaks output into later ones. The test was erroneously marked as flaky
instead of skipped, but now it's good.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
https://bugs.webkit.org/show_bug.cgi?id=119710

Reviewed by Darin Adler.

No behavior change, no new tests needed.

* rendering/RenderObject.cpp: Remove unused parameter warning.
(WebCore::shouldRepaintFixedBackgroundsOnScroll):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1

No new tests since the test in the Blink change doesn't reproduce crash on WebKit.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
extract-localizable-strings doesn't know how to verify an existing strings file
https://bugs.webkit.org/show_bug.cgi?id=119704

Reviewed by Darin Adler.

* Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
exceptions file name to omitting the --exceptions option. Added a --skip option, changing
the way directories to skip are specified from prefixing the directory with a “-” to
specifying it with --skip.
Finally, added a --verify option. When specified, the strings file is not written to, but
instead read in and checked for consistency with the comments, keys and values derived from
the source files and the exceptions file. Missing keys, unused keys, mismatching values and
mismatching comments are reported as errors.
* Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
directories to skip and no exceptions file.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=119585

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::provisionalURL):
Implemented to pass provisionalURL of main frame to DumpRenderTreeChrome.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(pathSuitableForTestResult):
Return path string that's relative to main frame URL, or just file name if
the resource is not in the same directory subtree.
Referenced WebKitTestRunner code in r153852.
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Move Clipboard::declareAndWriteDragImage to DragController
https://bugs.webkit.org/show_bug.cgi?id=117683

Reviewed by Brent Fulgham.

* dom/Clipboard.h: Removed declareAndWriteDragImage.

* page/DragController.cpp:
(WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
is now refactored into this function.
(WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
because declareAndWriteDragImage needs to be a member function, for Mac at least.

* page/DragController.h: Added declareAndWriteDragImage.

* page/efl/DragControllerEfl.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
It would be better to delete this file rather than having these placeholders.
I don't think EFL actually has drag support, and it makes work to have to keep
source files up to date that are really unused.

* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls to DragClient, which
does the work.
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
* page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Uses Pasteboard functions to
do the work.

* platform/Clipboard.h: Changed the pasteboard function to return a non-const reference.
For now, it's not clear what const will mean for pasteboards, and it's currently not
possible to write to a const pasteboard, which we need to do in the new
DragController::declareAndWriteDragImage functions.

* platform/Pasteboard.h: Added a new writeMarkup function, implemented only for Windows
at this time.

* platform/efl/ClipboardEfl.cpp: Deleted declareAndWriteDragImage.
* platform/gtk/ClipboardGtk.cpp: Ditto.
* platform/ios/ClipboardIOS.h: Ditto.
* platform/ios/ClipboardIOS.mm: Ditto.
* platform/mac/ClipboardMac.mm: Ditto.
* platform/qt/ClipboardQt.cpp: Ditto.
* platform/win/ClipboardWin.cpp: Ditto.

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writePlainTextToDataObject): Took out a pointless line of code.
(WebCore::Pasteboard::writeMarkup): Added. Currently implemented only for Windows.
This factors out a significant piece of DragController::declareAndWriteDragImage,
and will probably be handy for other platforms later.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Autotools] Adjust the help string for the configure's --enable-optimizations flag
https://bugs.webkit.org/show_bug.cgi?id=119682

Reviewed by Martin Robinson.

* Source/autotools/ReadCommandLineArguments.m4: Remove the 'GCC only' part of the help
string for the --enable-optimizations flag. This is not true and can lead to confusion
since the optimizations can be applied when compiling with Clang as well.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
extract-localizable-strings output is not suited for parsing by Xcode
https://bugs.webkit.org/show_bug.cgi?id=119728

Reviewed by Darin Adler.

Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
removed “ERROR” since messages that refer to a line in a file are shown as error by default,
added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
with 0).

* Scripts/extract-localizable-strings:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERTION FAILED: type() == Percent in WebCore::Length::percent
https://bugs.webkit.org/show_bug.cgi?id=116715

Reviewed by Darin Adler.

Source/WebCore: 

Allow the Calculated type in the Length::percent method that returns the Length's
float value. This reflects the changes in r110148 that adjusted the Length::isPercent
method to return true for Length objects of either Percent or Calculated type.

Test: fast/css/calculated-length-as-percent-crash.html

* platform/Length.h:
(WebCore::Length::percent): Assert that Length::isPercent is true when Length::percent
is called, ensuring the Length's type is either Percent or Calculated.

LayoutTests: 

Add the test case, as produced by the Fuzzinator, that was causing assertions
in Length::percent due to Length objects of the Calculated type not being treated
as holding a proper percent value in that method, despite Length::isPercent
returning true for Length objects of either Percent or the Calculated type.

* fast/css/calculated-length-as-percent-crash-expected.txt: Added.
* fast/css/calculated-length-as-percent-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix null dereference in HTMLAnchorElement::sendPings when frame is not attached to a page
https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Add a regression test for r153975.

* fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt: Added.
* fast/html/detach-frame-while-clicking-on-anchor-with-ping.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Windows build fix attempt after r153978.

* page/win/DragControllerWin.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Another Windows build fix attempt after r153978.

* page/win/DragControllerWin.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153984 268f45cc-cd09-0410-ab3c-d52691b4dbfc