That makes sense to me, it seems like unnecessary busy work to pull all the
strings out and put them somewhere else.


On Mon, Aug 26, 2013 at 5:12 PM, Michael Babker <notifications@github.com>wrote:

> In libraries/cms/helper/media.php:
>
> > +	/**
> > +	 * Checks if the file can be uploaded
> > +	 *
> > +	 * @param   array   $file  File information
> > +	 * @param   string  $err   An error message to be returned
> > +	 *
> > +	 * @return  boolean
> > +	 */
> > +	public function canUpload($file)
> > +	{
> > +		$params = JComponentHelper::getParams('com_media');
> > +
> > +		if (empty($file['name']))
> > +		{
> > +			$app = JFactory::getApplication();
> > +			$app->enqueueMessage(JText::_('COM_MEDIA_ERROR_UPLOAD_INPUT'), 'notice');
>
> CMS folder is our library, so it's easy for us to couple it to JLanguageand
> JText. So I'd go with using the old JLIB_ prefix and updating the strings.
>
> Unrelated, but I'm pretty sure we can clean up the en-GB.ini and
> en-GB.lib_joomla.ini files with all the language decoupling that did take
> place, probably clear out quite a few lines in there.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/joomla/joomla-cms/pull/1823/files#r5990113>
> .
>