Yes, good point, i will fix that.

This message was typed with haste on a tiny keyboard with no tactile feedback.

On Mar 20, 2013, at 2:10 PM, Mike Larsson <notifications@github.com> wrote:

> In webpagemaker/health_check/tests.py:
> 
> > +
> > +    @mock.patch('django.conf.settings.HEALTH_CHECK_PASSWORD', 'hi')
> > +    def test_returns_401_when_auth_header_creds_are_not_b64encoded(self):
> > +        response = self.client.get('/health_check',
> > +                                   HTTP_AUTHORIZATION='basic lol')
> > +        eq_(response.status_code, 401)
> > +
> > +    @mock.patch('django.conf.settings.HEALTH_CHECK_PASSWORD', 'hi')
> > +    def test_returns_401_when_auth_header_creds_do_not_split(self):
> > +        response = self.client.get('/health_check',
> > +                                   HTTP_AUTHORIZATION='basic bG9s')
> > +        eq_(response.status_code, 401)
> > +
> > +    @mock.patch('django.conf.settings.HEALTH_CHECK_PASSWORD', 'hi')
> > +    def test_returns_401_when_auth_header_username_is_not_correct(self):
> > +        creds = base64.b64encode('somebody:badpassword')
> Should this line be somebody:hi to ensure it's the bad username that's causing the 401?
> 
> —
> Reply to this email directly or view it on GitHub.