Refactored vcap_services into computed_environment_json, which contains the other evironment json variables in addition to vcap_services. This was done to prevent the need for creating additional logic on the client side in the future. Also added additional test coverage for the form of vcap_services. Minor formatting fixes.
Refactored app.rb computed_environment_json into 2 methods: computed_environment_json and helper method vcap_services. Expanded test coverage based on existing dea_next tests.
Added more ported DEA tests. Changed structure of vcap_services to more closely mirror the data structure that is producted in the DEA.
Refactored the base environment_json tests into a shared example to test both environment_json and computed_environment_json.
Refactored computed_environment_json to make use of environment_json to produce the base response. Added test coverage to test that computed_json response contains the normal response in additon to vcap_services.
Refactored vcap_services into two methods to better encapsulate
disparate functionality. Removed extraneous let statements from
app_spec. Corrected whitespacing in app_spec.