needs to pass query params