SyntheticClient.cc: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CephBroker.h: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
TextTable: pass const string by refrence to define_column()

Pass 'const string heading' by reference to define_column().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
common/armor.c: reduce scope of some variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cls_acl.cc: remove unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cls_crypto.cc: remove some unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
ceph_context.cc: remove unused variable 'args' from do_command

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
code_environment.cc: move variable ret in get_process_name()

Move 'ret' in get_process_name() to the correct block to suppress
warning about unused variable in cppcheck.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
config.cc: remove unused variable 'val' from parse_injectargs()

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
obj_bencher.cc: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
pick_address.cc: pass const string by refrence

Pass 'const string networks' by reference to find_ip_in_subnet_list().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
common/secret.c: reduce the scope of some variables

Reduce the scope of error_buf to the place where it's used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CrushCompiler.cc: remove duplicate if/else branches

Fix duplicate content of a if/else branch. Remove the
complete if/else around the content.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
crush/builder.c: reduce scope of oldsize in crush_add_rule()

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
bloom_filter.hpp: check for self assignment

Check for self assignment in operator= to avoid problems with
dynamic memory (cppcheck).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
key_value_store/cls_kvs.cc: remove unused variable dupmap

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
kv_flat_btree_async.cc: remove some unreachable break statements

Remove unreachable break statements after return calls in a switch.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
kv_flat_btree_async.cc: remove unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Merge pull request #81 from dalgaaf/wip-da-sca-style-1

Fix some smaller style issues

Reviewed-by: Sage Weil <sage@inktank.com>