On Thu, 7 Mar 2013, Hannes Magnusson wrote:

> > +
> > +	mongo_manager_log(manager, MLOG_CON, MLOG_INFO, "Checking if %s is BLACKLIST", hash);
> > +	if (manager->blacklist_count == 0) {
> > +		mongo_manager_log(manager, MLOG_CON, MLOG_INFO, "BLACKLIST empty");
> > +		return 0;
> > +	}
> > +
> > +	for (i=0; i<manager->blacklist_count; i++) {
> > +		if (strcmp(manager->blacklist[i], hash) == 0) {
> > +			mongo_manager_log(manager, MLOG_CON, MLOG_INFO, "%s IS BLACKLIST", hash);
> > +			return 1;
> > +		}
> > +	}
> > +
> > +	mongo_manager_log(manager, MLOG_CON, MLOG_INFO, "...nope");
> > +	return 0;
> 
> Reworded.
> 
> Well, if you hit the blacklist then I think that should definitely be 
> a INFO log as there is a problem with the replicaset. When there is no 
> problem.. that could be a FINE entry I suppose.. Doesn't make a big 
> difference to me.. Want it changed?

Please please, as, it makes debugging logs a bit less noisy. When you're 
at it, could you also use '%s' instead of just a naked %s in every case 
(you've already done that once).