Fix reversed current/expected type

Fix some reversed type of arm pattern and type of search pattern
in error message.
auto merge of #5070 : youknowone/rust/struct-match2, r=nikomatsakis

It is reversed that type of arm pattern and type of search pattern
in error message.
Remove legacy object creation mode, and convert remaining uses of it