Aggregator is probably the best. I'll rename.

Frank Austin Nothaft
fnothaft@alumni.stanford.edu
202-340-0466

On Oct 24, 2013, at 3:22 PM, Matt Massie <notifications@github.com> wrote:

> In adam-commands/src/main/scala/edu/berkeley/cs/amplab/adam/commands/PileupCompressor.scala:
> 
> > +    }
> > +
> > +    List (combineEvidence(pileupList))
> > +  }
> > +
> > +  def compress (pileups: RDD[ADAMPileup]): RDD[ADAMPileup] = {
> > +    def flatten (kv: ((Option[Long], Option[Base], Option[Integer], Option[CharSequence]),Seq[ADAMPileup])): List[ADAMPileup] = {
> > +      compressPileup (kv._2.toList)
> > +    }
> > +
> > +    pileups.groupBy (mapPileup(_))
> > +      .flatMap (flatten(_))
> > +  }
> > +}
> > +
> > +class PileupCompressor (protected val args: PileupCompressorArgs)
> Calling this PileupCompressor is a little confusing. I thought it was referring to compression (e.g. gzip, bzip2, etc) but it's really about reducing the data. How about we call this PileupReducer or PileupSummarizer or PileupAggregator or somesuch?
> 
> —
> Reply to this email directly or view it on GitHub.
>