Revert r1485848 because it caused segfaults in 'svn diff' on a working
copy of Subversion's own trunk. The working copy is corrupted after
the crash, some working files contain binary garbage.

Also reported to dev@.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486044 13f79535-47bb-0310-9956-ffa450edef68
Make the output of 'svnadmin crashtest' less misleading.

It used to print a message such as:

  $ svnadmin crashtest repos 
  subversion/svnadmin/svnadmin.c:631: (apr_err=SVN_ERR_ASSERTION_FAIL)
  svn: E235000: In file 'subversion/svnadmin/svnadmin.c' line 631: internal malfunction
  Abort trap (core dumped) 

This makes it hard to tell whether the program operated as expected.
It can also be surprising for users who don't know the purpose of
the crashtest command.

Instead, print the following:

  $ svnadmin crashtest repos 
  Successfully opened repository 'repos'.
  Will now crash to simulate a crashing server process.
  Abort trap (core dumped) 

Inspired by: Jan Smets (via #svn IRC)

* subversion/svnadmin/svnadmin.c
  (crashtest_malfunction_handler): New. Just calls abort() and unlike the
   default malfunction handler it doesn't print anything.
  (subcommand_crashtest): Install the new custom malfunction handler.
   Print an informative message after opening the repository, before crashing.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486046 13f79535-47bb-0310-9956-ffa450edef68
Test an edge case.

* subversion/tests/libsvn_fs/fs-test.c
  (almostmedium_file_integrity): New test, sibling to medium_file_integrity()
    and large_file_integrity().

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486057 13f79535-47bb-0310-9956-ffa450edef68
Re-apply r1485848 with an extra fix that prevents the buffer overflow
plus is easier to understand.

* subversion/libsvn_subr/subst.c
  (translate_chunk): quickly scan for EOL if there is keyword substitution


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486058 13f79535-47bb-0310-9956-ffa450edef68
Add --target options to create-tag and post-candidates release.py subcommands.

This makes it easier to use these commands on a different machine than where
the tarballs were built.

* tools/dist/release.py
  (sign_candidates, get_sha1info, get_siginfo): Factor common code into ...
  (get_target): ... this new function.
  (post_candidates, create_tag): Use get_target() to support target option.
  (main): Add --target to post-candidates and create-tag subcommands.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486069 13f79535-47bb-0310-9956-ffa450edef68
Fix expansion of custom keywords with values that contain '='.

* subversion/libsvn_subr/subst.c
  (build_keywords): Don't use svn_cstring_split() to find the '=' separator.
    It is not a suitable API for this purpose. Instead, scan for the first
    occurrence of '=' and split keyword name from custom format there.

* subversion/tests/libsvn_subr/subst_translate-test.c
  (test_svn_subst_build_keywords3): Expand to cover a custom keyword with '='.
   Also assert that a non-NULL expanded keyword value is returned to avoid
   crashing this test with a NULL-deref.

Reported by: Lorenz (lorenznl -@T- yahoo.com)


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486072 13f79535-47bb-0310-9956-ffa450edef68
Code formatting changes only.

* subversion/libsvn_subr/auth.c
  (svn_auth_first_credentials): Balance braces.
  (svn_auth_next_credentials, svn_auth_save_credentials): Fix
    space-before-parent instances.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1486094 13f79535-47bb-0310-9956-ffa450edef68
On the fsfs-format7 branch: sync with /trunk up to and including r1486307.

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/fsfs-format7@1486308 13f79535-47bb-0310-9956-ffa450edef68