Merge remote-tracking branch 'org/buildbot-0.8.8' into buildbot-0.8.8
Reintroduce deprecated `workdir` property.

It is unfortunatley named, but dropping it now doesn't provide a clear
migration path. Supporting both for at least a version allows smoother
migration.
Rework locating config file for checkconfig and upgrade-master.

This changes the logic of checkconfig so that,
1. If a file is passed, that file is used.
2. If a directory is passed containing `buildbot.tac`, that file is
   loaded and `configfile` is defined there, that file is used.
3. If `buildbot.tac` doesn't exist, or doesn't define `configfile`,
   `master.cfg` from that directory is used.

The logic for upgrade-master is similar, except only directories are
supported, so (1) is skipped.
Use twisted.python.deprecate.deprecatedModuleAttribute to deprecate SetProperty.
Move buildslave code around to match organization of openstack latent slave.
Report `SyntaxError` or `ImportError` from `checkconfig` and `upgrade-master`.
Merge 'locate-config': Rework locating config file for checkconfig and upgrade-master.

This changes the logic of checkconfig so that,
1. If a file is passed, that file is used.
2. If a directory is passed containing buildbot.tac, that file is
loaded and configfile is defined there, that file is used.
3. If buildbot.tac doesn't exist, or doesn't define configfile,
master.cfg from that directory is used.

The logic for upgrade-master is similar, except only directories are
supported, so (1) is skipped.
Fix python2.5 syntax errors.
Backport docs highlighting check monkey-patch for Sphinx starting from v0.6.6

Currently host that builds documentation uses Sphinx v1.0.7.

This monkey-patched tested with Sphinx (few) versions starting from v1.0,
because Buildbot's master/docs/bbdocs/ext.py depends on features
introduced there (Sphinx Domains).
Fix highligting issue with Sphinx 1.0 (and in 1.0.7)

Old Sphinx versions not highlighted unparsable Python code (new one
does).
Fix typos: "defered", "accecpts", "atomicitiy"
check that configured cache sizes are >= 1

LRU cache implementation assumes that the cache is at least 1
element large. Catch invalid master configurations where cache
sizes less then 1 are specified.
Replace use of deprecated unittest.TestCase.assert_() with assertEqual/NotEqual etc methods

If newer version of unittest will be used, self.assertEqual(..., None)
should be replaced with self.assertNone(...), same with not equal to
None checks.
Merge branch 'backport_docs_highlighting_monkey_patch' of git://github.com/vrutsky/buildbot
Merge branch 'typos4' of git://github.com/vrutsky/buildbot
Merge branch 'replace_assert_in_CVSMaildirSource_tests' of git://github.com/vrutsky/buildbot
Merge branch 'check-cache-sizes' of git://github.com/elmirjagudin/buildbot
Fix typos, add missing dot

Typos: "eveything", "formatated", "afer", "loking",
"buildbot.test.regrssions", "eror", "concatentate".
Merge pull request #783 from vrutsky/typos

Fix typos
fix gitlab tests to not rely on json error messages