I think bigger than 100char is not a crime, it it's more readable , go for
it :)


On Thu, Jul 4, 2013 at 3:15 PM, Sébastien Coavoux
<notifications@github.com>wrote:

> In shinken/objects/schedulingitem.py:
>
> > @@ -540,11 +543,13 @@ def schedule(self, force=False, force_time=None):
> >              if self.next_chk <= now:
> >                  # maybe we do not have a check_period, if so, take always good (24x7)
> >                  if self.check_period:
> > -                    self.next_chk = self.check_period.get_next_valid_time_from_t(self.next_chk + time_add)
> > +                    self.next_chk = \
> > +                        self.check_period.get_next_valid_time_from_t(self.next_chk + time_add)
>
> In those 2 cases it's hard to be under 100 char because of the method name
> :) . I can split after the '(' or + if it more readable. Otherwise, I put
> this back but the length will be bigger than 100.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/naparuba/shinken/pull/918/files#r5030824>
> .
>