got basic implementation working still one failing test