Fix #6561 - Better looking puppetdoc CSS for rdoc mode

From: Duncan Phillips <duncan@yola.com>

Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
Restrict the regex to only allow 0 or 1. Not 10.
(#21478) Add plymouth-ready to excludes list

An update to Ubuntu 12.04's plymouth package, version 0.8.2-2ubuntu31,
introduces a new upstart service, plymouth-ready in order to fix
the bug detailed here:
https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/982889

This new service uses instances, which puppet does not yet fully
support, and attempting to retrieve the status of this job causes
puppet to fail (for example when running "puppet resource service").

Adding plymouth-ready to the excludes list allows puppet to output
the status of services that it can handle competently while avoiding
the service introduced by this package.
(#18255) - Follow http redirections

This patch adds support for HTTP redirection in the Puppet HTTP
client.

The http client includes a redirection limit, and recreate the
redirected connection with the same certificates and store as the
original (as long as the redirect new location is ssl protected).

This patch allows redirection following for all HTTP methods, which
in the Puppet ecosystem shouldn't be an issue.

Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>

Use a loop - temp commit
(#6561) increase rdoc output font size and fix facts display

Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
(Maint) Fix warnings issued by yard

There were many uses of incorrect tags (@returns instead of @return),
unnamed params (@params without specifying which param) and inccorect
use of multiple variations (@params for the same param many times
instead of using @overload). This fixes many, but not all of the
warnings issued by yard when it generates documentation.
(maint) Fix rspec warnings

Running specs with rspec 2.13 caused a lot of warnings. Many of them actually
exposed preexisting bugs, the most common being a syntax error when expecting
an Exception. These are worth fixing even if we don't bump to rspec 2.13.
(maint) Extract puppet setting types to constant
(#6112) Acceptance test handles host with uninitialized ssl

Running the acceptance test on Jenkins discovered a third case, and
helped use clarify behavior for the expected cases on an initialized
master/agent.  The third case is a host which has not initialized yet
(has no ssl info created or cached) which is similar to what happens
when a master initializes through a 'puppet master' call, but this is
through a 'puppet generate' call and what the node should be capable of
as a master or agent afterwords is ambiguous.

Acceptance test now checks this case, showing that a cert does generate
in this instance, and leaves the host in an ambiguous state of ssl
configuration where they cannot authenticate with the master afterwords.
(#6112) Clearing test of whether puppet agent fails

Whether a puppet agent -t fails after a puppet cert generate in a bare
host (no ssl setup) seems to have platform specific issues which need to
be figured out.  It fails for me locally in Ubuntu, and the Lucid
Jenkins job failed, but RHEL did not.

Commenting this portion out and marking pending until we have more time
to investigate.
Merge pull request #1753 from pcarlisle/rspec-deprecations

(maint) Fix rspec warnings
Merge pull request #1756 from jpartlow/issue/master/6112-fixing-acceptance-test

(#6112) Acceptance test handles host with uninitialized ssl
(#6112) Acceptance test handles host with uninitialized ssl

Running the acceptance test on Jenkins discovered a third case, and
helped use clarify behavior for the expected cases on an initialized
master/agent.  The third case is a host which has not initialized yet
(has no ssl info created or cached) which is similar to what happens
when a master initializes through a 'puppet master' call, but this is
through a 'puppet generate' call and what the node should be capable of
as a master or agent afterwords is ambiguous.

Acceptance test now checks this case, showing that a cert does generate
in this instance, and leaves the host in an ambiguous state of ssl
configuration where they cannot authenticate with the master afterwords.
Revert "Merge pull request #1756 from jpartlow/issue/master/6112-fixing-acceptance-test"

This reverts commit 77aa6f61ba2d4d5d85eb4ae967322a9d41d11e5f, reversing
changes made to c0d1eafa19da0a783fec8670500ef08fb7c23d5c.

Joshua Partlow @finch, we just passed each other on #1756; andy and kylo had some
changes they wanted. Sorry for not getting that in the pr. There must be
a better way to coordinate on these things

Adrien Thebo @jpartlow I was too eager to merge that
Adrien Thebo should I revert it for now?

Joshua Partlow yeah if you would
Merge pull request #1754 from adrienthebo/maint_setting_type_constant

(maint) Extract puppet setting types to constant
Merge pull request #1757 from jpartlow/issue/master/6112-fixing-acceptance-test

(#6112) Acceptance test handles host with uninitialized ssl
(maint) Fix calling wrong should method on properties

Puppet::Property defines #should, which conflicts with rspec #should. This
fixes several cases where tests were calling #should directly on a Property
instance.
(#21508) Make local variables available to templates as instance vars

The problem was that templates reference scope variables using
instance variables e.g. @myvar, these were configured from the
hash returned by Scope#to_hash. That method did not consider
ephemeral scopes.

The solution was to add collection of the emphmeral scopes' (that
represent local scopes) variables and include them in the hash.

As before, the match scopes (i.e. for $0 - $n) are not included in
the result.
Redmine #21709
Discussed with jamesturnbull to submit this as a workaround.
(#19906) Wrong error from "upgrade" with JSON output when module already installed