It can only break for strings with a first char of '.' which eval to false
- are there any of these?



On 19 Oct 2013, at 09:38, Andreas Gohr <notifications@github.com> wrote:

In inc/pageutils.php:

> @@ -396,7 +396,7 @@ function resolve_id($ns,$id,$clean=true){
>
>      // if the id starts with a dot we need to handle the
>      // relative stuff
> -    if($id{0} == '.'){
> +    if($id && $id{0} == '.'){

This breaks for an ID named 000 or any other string evaluating to false.

Maybe we should introduce a helper function that checks isset() and === ''?

—
Reply to this email directly or view it on
GitHub<https://github.com/splitbrain/dokuwiki/pull/380/files#r7078764>
.