Web Inspector: [Canvas] UI: add control buttons for doing the replay steps
https://bugs.webkit.org/show_bug.cgi?id=106788

Reviewed by Pavel Feldman.

Adding UI control buttons for doing the Canvas replay steps.
Drive-by: fixed a bug in DataGrid (found by the JSCompiler).

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._createControlButton):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
* inspector/front-end/DOMExtension.js:
(Element.prototype.enableStyleClass):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGridNode):
* inspector/front-end/canvasProfiler.css:
(.canvas-replay-image):
(.canvas-replay-image.wait):
(.canvas-replay-controls):
(.canvas-replay-log):
(.canvas-control-button):
(.canvas-control-button:active):
(.canvas-control-button:disabled):
(.canvas-control-button img):
(.canvas-replay-first-step img):
(.canvas-replay-next-step img):
(.canvas-replay-prev-step img):
(.canvas-replay-last-step img):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Do not pass nil when initializing legible output
https://bugs.webkit.org/show_bug.cgi?id=106799

Reviewed by Jessie Berlin.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]
    wants an empty NSArray rather than nil.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Audit Tool's False Positive on Set-Cookie header
https://bugs.webkit.org/show_bug.cgi?id=106794

Reviewed by Pavel Feldman.

Source/WebCore:

Header value is now returned as undefined if there is no such header as it was before regression.

Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._headerValue):

LayoutTests:

* http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: add text editor formatter test
https://bugs.webkit.org/show_bug.cgi?id=106705

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adds a test checking text editor formatting.
The test creates a new text editor and fills it in with some
code by the means of simulated key and textInput events.

* inspector/editor/text-editor-formatter-expected.txt: Added.
* inspector/editor/text-editor-formatter.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
MediaStream API: Update MediaStreamTrack::readyState to match specification
https://bugs.webkit.org/show_bug.cgi?id=106781

Reviewed by Adam Barth.

Source/WebCore:

MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.

Existing tests expanded to cover patch.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):
* Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Make an Isolate parameter mandatory in wrap()
https://bugs.webkit.org/show_bug.cgi?id=106783

Reviewed by Adam Barth.

Now it's safe to make an Isolate parameter in wrap().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::wrap):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
https://bugs.webkit.org/show_bug.cgi?id=106779

Reviewed by Adam Barth.

This is one of steps to make an Isolate parameter mandatory.

No tests. No change in behavior.

Source/WebCore:

* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):

Source/WebKit/chromium:

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::interruptAndDispatch):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
https://bugs.webkit.org/show_bug.cgi?id=106784

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Source/WebKit/chromium: 

Unreviewed build fix.

It turns out that the change behind this flag causes crashes and image errors.

* skia_webkit.gyp:

LayoutTests: 

Unreviewed expectations clean-up.

Removing the expectations associated with the flag.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
as flaky on Chromium Win Debug bots.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html
https://bugs.webkit.org/show_bug.cgi?id=106805

Patch by Michael Pruett <michael@68k.org> on 2013-01-14
Reviewed by Tony Chang.

V8 prepends "Uncaught " to uncaught exceptions, while JSC does not.
Either form of the error message should be acceptable.

* storage/indexeddb/transaction-complete-workers.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
as flaky on Chromium Debug bots.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106785

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::setStatusText):
(WebTestRunner::WebTestProxy::didStopLoading):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::TestRunner::dumpWindowStatusChanges):
(WebTestRunner::TestRunner::dumpProgressFinishedCallback):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didStopLoading):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didStopLoading):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Zoom is still possible when user-scalable=no
https://bugs.webkit.org/show_bug.cgi?id=106809

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by George Staikos.

PR: 274566
On wordpress.com, the contents were rendered at the width 343 which was
1 css pixel larger than the expected device-width 342 so that we didn't
respect the viewport.
There was a RenderBlock on the page which contained "\n" and an
inline-block. "\n" took 0.78 width and the inline-block took 342 width
and they were unfortunately placed in the same InlineBox which caused
the contents width 1 css pixels larger than the device-width.
Allow the contents width to be 1 css pixel larger and still respect the
viewport in such a special case.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::respectViewport):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
https://bugs.webkit.org/show_bug.cgi?id=106807

Reviewed by Pavel Feldman.

Open dedicated worker inspector 600x600 by default and remember its size
after resizing.

* inspector/front-end/Settings.js:
* inspector/front-end/WorkerManager.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
https://bugs.webkit.org/show_bug.cgi?id=106806

Reviewed by Levi Weintraub.

This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.

* editing/spelling/spellcheck-sequencenum-expected.txt:
* editing/spelling/spellcheck-sequencenum.html:
* platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
in Chromium test expectations. Tony fixed the issue in r139636.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory
https://bugs.webkit.org/show_bug.cgi?id=106718

Reviewed by Andreas Kling.

Type assertion was missing a new type.

* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Clean up WebVTTNodeType code
https://bugs.webkit.org/show_bug.cgi?id=106714

Reviewed by Tony Chang.

There's no reason for so many methods just to compare some enums.
The existing code can also be simplified quite a bit.

No new tests, just refactoring.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* dom/Element.cpp:
(WebCore::Element::webVTTNodeType):
(WebCore::Element::setWebVTTNodeType):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(WebCore::ElementRareData::setWebVTTNodeType):
(WebCore::ElementRareData::webVTTNodeType):
(ElementRareData):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
* html/track/TextTrack.h:
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::markFutureAndPastNodes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139639 268f45cc-cd09-0410-ab3c-d52691b4dbfc