Shouldn't this be an Enum rather than a regular class?

-Darius (by phone)
On Dec 19, 2013 3:34 PM, "wluyima" <notifications@github.com> wrote:

> In api/src/main/java/org/openmrs/CareSetting.java:
>
> > + * Copyright (C) OpenMRS, LLC.  All Rights Reserved.
> > + */
> > +package org.openmrs;
> > +
> > +public class CareSetting implements java.io.Serializable {
> > +
> > +	private static final String OUT_PATIENT = "OUTPATIENT";
> > +	private static final String IN_PATIENT = "INPATIENT";
> > +
> > +	public static CareSetting OUTPATIENT = new CareSetting(OUT_PATIENT);
> > +	public static CareSetting INPATIENT = new CareSetting(IN_PATIENT);
> > +
> > +	private String careSetting;
> > +
> > +	public CareSetting() {
> > +		this.careSetting = OUT_PATIENT;
>
> I don't think this is quite right, i would rather leave careSetting
> property null
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openmrs/openmrs-core/pull/480/files#r8488765>
> .
>