Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when failing to construct_limited_ids_condition.
Add coverage for the fact that pluck without an argument returns all the table's columns.
No point in memoizing a simple literal string.
Make NullRelation a bit more like a real relation by returning 0 for #calculate(:count)
Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.

This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control.
Prevent side effects in `Hash#with_indifferent_access`.
Fixing a failing railtie test by using the ENV variable to specify a
particular controller to search for in rake routes.
Allow Date to be compared with Time (like it was possible to compare Time with Date)
Merge pull request #10809 from wangjohn/fix_failing_railtie_test

Fixing a failing railtie test by wrapping the command inside of sh -c
Revert "Merge pull request #4490 from EmmanuelOga/master"

This behaviour doesn't actually make sense, the context of
the child should not be affected by the parent. See #10492.

This reverts commit 5f8274efe128ffeec8fa3179460f5167a078f007, reversing
changes made to 81e837e810460d066a2e5fc5a795366ec8ab2313.
The behavior we had in place in rc1 was actually to convert to DateTime and use <=> from there. Restore that.
Merge branch 'master' of github.com:rails/rails
Replace comment about Sprockets stub directive with a link to README about all directives
Merge pull request #10784 from senny/10526_prevent_key_transformation

Prevent side effects in `Hash#with_indifferent_access`.
Fixes #10432 add_column not creating array columns in PostgreSQL

When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34)
`add_column` was no longer receiving the column options directly. This
caused the options to be lost along the way.
Removing use of subclassed application constant and instead using the
more agnostic Rails.application syntax. This means tests will be more
portable, and won't rely on the existence of a particular subclass.
Merge pull request #10832 from wangjohn/removing_use_of_application_constant

Removing use of subclassed application constant and replacing with Rails.application
Dry-up ActionDispatch::Routing autoloads
Refactor ActionDispatch::Http::Parameters#normalize_encode_params
Merge pull request #10838 from gsamokovarov/routing-autoload_under

DRY-up ActionDispatch::Routing autoloads