working on attribute class