My opinion is that we should generally avoid sending events during modeling since modeling only happens every 12 hours by default. If this is important enough to send an event about, we should probably be monitoring it and sending events in the normal way.

The no-op getErrorNotification method will also be a problem. It will cause Zenoss to think that modeling changed something on the device every modeling cycle. This causes an invalidation on the device which gets picked up by Zenoss and processed for distribution to the appropriate collector. On a system monitoring lots of Windows devices this constant model churn will be a big problem. So any setter methods called by modeler plugins need to have functioning getters.