On Wed, Mar 27, 2013 at 8:36 AM, Alexandre Gramfort <
notifications@github.com> wrote:

> In mne/epochs.py:
>
> > @@ -386,26 +415,12 @@ def _get_epoch_from_disk(self, idx, verbose=None):
> >          if start < 0:
> >              return None
> >          epoch, _ = self.raw[self.picks, start:stop]
> > -
> > -        if self.proj and self._projector is not None:
> > -            logger.info("SSP projectors applied...")
> > +        if self.reject is not None and self.proj == False:
> > +            self._epoch_tmp = epoch.copy()
>
> doing a careful review now I notice this self._epoch_tmp which I don't
> like much.
> Wouldn't be simpler to have _get_epoch_from_disk be able to return both
> versions of epochs (with and w/o SSP)?
>
> something like
>
> epoch_ssp, epoch_raw, = self._get_epoch_from_disk(idx, with_no_proj=True)
>
>
sure! that could work. but it would require some extra handling for cases
where we don't have projs,
e.g. return None / empty array and check before passing to
self._is_good_epoch
But you would agree on keeping the _preprocess_epoch private method?

> and then you do
>
> is_good, offenders = self._is_good_epoch(epoch_ssp)
>
> and decide which one to keep?
>
>  —

> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/487/files#r3546180>
> .
>