Remove unnecessary returns

* remove duplicated xtrace
* remove some unnecessary return

Change-Id: If9e0a979e0bd5a334e82d42572ac0b149de341d7
Create tools/install_prereqs.sh

* Factor system package prereq installs out to tools/install_prereqs.sh
* Set minimum time between runs with PREREQ_RERUN_HOURS
  default = 2 hours
* Create re_export_proxy_variables

Change-Id: I4a182b1da685f403d6abdd8540d2114796c01682
Fix script matching in exercise.sh

This prevents false matches in exercise skip test

Change-Id: I5656a20bcf11b2ccaf55e280655d0600124adedc
Fix selection of image(s) tested by tempest.

The variable DEFAULT_IMAGE_NAME is set to 'cirros-0.3.0-x86_64-uec' by default.
This will cause configure_tempest to 'exit 1' and abort stack.sh if an image
with that name is not uploaded to glance. According to the relevant code
comment, this behaviour is incorrect. Updated code to match behaviour described
in comment: If image with name matching DEFAULT_IMAGE_NAME exists, use it for
both primary and secondary test image otherwise select first image and, if
available, second image listed by glance. Will still 'exit 1' if no images
are available at all (though it probably shouldn't).

Change-Id: I92773d4afd52cf533d16772ae2a087e23e206f8c
Fixes: bug #1092713
Use new RPC notifier

Stop using the deprecated rabbit_notifier.

Change-Id: I84574c555031b23fb5f256d248af1cdafc8979ce
Signed-off-by: Julien Danjou <julien@danjou.info>
Holiday docs and comment formatting cleanup

Change-Id: Ia4ca88c67d3b94e306a79a669805a2fa1b0dc069
Merge "Create tools/install_prereqs.sh"
Adjust CINDER_SECURE_DELETE flag to cinder changes

Cater for the pending more general cinder support
for configurable volume wiping method at:
https://review.openstack.org/#/c/12521

This change is done here first so as to not
trigger a CI lockup when the referenced patch above lands.
When that's in place, we can remove the older
secure_delete config adjustment in a subsequent patch.

Change-Id: I73fe2e0d1cf2815ab6025121584951cb5ff56fa3
Revert "Create tools/install_prereqs.sh"

This reverts commit 7be0b04

This work breaks the ability to do multi database installs,
revert until there is a working solution here, as this is going
to make fixing postgresql in tempest impossible.

Change-Id: I39a2b78542fe60233806d1005186ce1b31d4be17
Enable millisecond logging for nova and cinder

Change-Id: Ic28867ae9a436e81c7f2fcf79f40a1ecc251072c
Use 'which pip' rather than /usr/bin/pip

Bug 1095472: Bugfix to use 'which pip' rather than assume pip always lives in /usr/bin

Change-Id: I0cc8a5e35306372653c3c27da9504c64e39d56dd
Add libjs-jquery-tablesorter to package list.

Coverage html reports have a symlink to jquery.tablesorter.min.js
which is provided by libjs-jquery-tablesorter. If the package is
not installed coverage html reports will have a broken symlink to
that file.

Change-Id: I7496a22f36d4f2fda2f030962b10d5afbc8f448f
Merge "Minor fixes for lib/baremetal"
Merge "Fix selection of image(s) tested by tempest."
Merge "Enable millisecond logging for nova and cinder"
Merge "Add libjs-jquery-tablesorter to package list."
Properly wait until volumes are gone in volumes.sh

A logic error in volume exercise's wait for volume deletion
causes the test to do the opopsite, and continue on even tho
the volume is in in the 'deleting' state.  If using a volume
backend that can quickly delete volumes (ceph), and the volume
is gone before entering the wait, the loop will spin, timeout
and fail the test.

Change-Id: I8e3d2aaa04e6a165e0dee32bedac97d35e13d5eb
Merge "Use 'which pip' rather than /usr/bin/pip"
Turn off tenant_isolation in tempest for quantum

Current tempest didn't create networks for each tenant, so let
tempest use demo tenant for tesing if we enable quantum.

Change-Id: I5f139b5f1bdf5c176130b8db9e896e2cb48b4420
Clean up cinder volume group rather than remove it

Removing the cinder volume group breaks devstack installations
that share that volume group with other logical volumes. It also was
leaking loopback devices.

Change-Id: Ice4470e06e08ce49a0e1f82af70abcc015c91c20