Only for the consistency, but, as you noted, it doesn't make much
difference at that stage. I am removing it and rerunning the test suit.


On Mon, Oct 14, 2013 at 11:49 AM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/expressions/TupleValueExpression.java:
>
> > @@ -243,15 +334,36 @@ public void resolveForTable(Table table) {
> >          setValueSize(column.getSize());
> >      }
> >
> > +    /**
> > +     * Given an input schema, resolve the TVE
> > +     * expressions.
> > +     */
> > +    public int resolveColumnIndexesUsingSchema(NodeSchema inputSchema) {
> > +        int index = inputSchema.getIndexOfTve(this);
> > +        if (index == -1 && m_childrenTVE != null) {
> > +            // Try to resolve column index using nested TVE
> > +            for (TupleValueExpression childTVE : m_childrenTVE) {
> > +                index = inputSchema.getIndexOfTve(childTVE);
> > +                if (index != -1) {
> > +                    // reset parent TVE table name and alias to the child ones.
>
> What is the benefit of resetting the table name and alias at this late
> stage? I'd avoid this if possible.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6946981>
> .
>