(from IRC)

<mcomella> rnewman: I feel like the idea of the counter is necessary in other places though, like the catch statement after uploadPayload() (https://github.com/mozilla-services/android-sync/pull/332/files#diff-55c5828bd1b4c8dee19430edddb04632R181)
<mcomella> rnewman: It seems weird to me that the Generator would own the success/failure counting when it's really the uploader that should know about this
<mcomella> rnewman: Since we're counting "upload" failures, not "generation" failures
<mcomella> rnewman: I should really be getting the Environment directly in ASC.upload(), and passing that to generateDocument, rather than re-retrieving the environment, however.

What do you think?