supported edit function finished