No strong feelings on my end.


2013/3/25 juliusv <notifications@github.com>

> In storage/metric/memory.go:
>
> > @@ -348,8 +348,20 @@ func (s memorySeriesStorage) Close() (err error) {
> >  	return
> >  }
> >
> > -func (s memorySeriesStorage) GetAllMetricNames() ([]string, error) {
> > -	panic("not implemented")
> > +func (s memorySeriesStorage) GetAllMetricNames() (metrics []string, err error) {
> > +	metricSet := map[string]bool{}
>
> It doesn't give me much except for Add()... and then I need to type-assert
> values as I read them out again. So I decided against it, but don't feel
> strongly about either way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/prometheus/prometheus/pull/98/files#r3518898>
> .
>