added propup and a test for it