finished sale module
ongoing refactoring fo sales controller