I'm not sure what you mean.


On Thu, Nov 7, 2013 at 10:37 AM, bcail <notifications@github.com> wrote:

> In bdrxml/rights.py:
>
> > +        groups, people = self._partition_users_groups(self.base_builder._readers | self.base_builder._owners)
> > +        rights.read_access_group = groups
> > +        rights.read_access_person = people
> > +
> > +        groups, people = self._partition_users_groups(self.base_builder._editors | self.base_builder._owners)
> > +        rights.edit_access_group = groups
> > +        rights.edit_access_person = people
> > +
> > +        groups, people = self._partition_users_groups(self.base_builder._discoverers | self.base_builder._owners)
> > +        rights.discover_access_group = groups
> > +        rights.discover_access_person = people
> > +
> > +        groups, people = self._partition_users_groups(self.base_builder._deleters | self.base_builder._owners)
> > +        rights.delete_access_group = groups
> > +        rights.delete_access_person = people
> > +
>
> I’m wondering if there’s an issue here assigning all the rights settings
> to the same groups/people lists that are getting updated. Do they all end
> up with the final delete members? Maybe not an problem, as long as it’s
> tested...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Brown-University-Library/bdrxml/pull/19/files#r7498866>
> .
>